Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: chrome/test/chromedriver/logging_unittest.cc

Issue 454133003: [ChromeDriver] Implementing tracing support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing nits Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/chromedriver/logging.cc ('k') | chrome/test/chromedriver/performance_logger.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/values.h" 5 #include "base/values.h"
6 #include "chrome/test/chromedriver/capabilities.h" 6 #include "chrome/test/chromedriver/capabilities.h"
7 #include "chrome/test/chromedriver/chrome/devtools_event_listener.h" 7 #include "chrome/test/chromedriver/chrome/devtools_event_listener.h"
8 #include "chrome/test/chromedriver/chrome/log.h" 8 #include "chrome/test/chromedriver/chrome/log.h"
9 #include "chrome/test/chromedriver/chrome/status.h" 9 #include "chrome/test/chromedriver/chrome/status.h"
10 #include "chrome/test/chromedriver/command_listener.h" 10 #include "chrome/test/chromedriver/command_listener.h"
11 #include "chrome/test/chromedriver/logging.h" 11 #include "chrome/test/chromedriver/logging.h"
12 #include "chrome/test/chromedriver/session.h"
12 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
13 14
14 namespace { 15 namespace {
15 16
16 const char* const kAllWdLevels[] = { 17 const char* const kAllWdLevels[] = {
17 "ALL", "DEBUG", "INFO", "WARNING", "SEVERE", "OFF" 18 "ALL", "DEBUG", "INFO", "WARNING", "SEVERE", "OFF"
18 }; 19 };
19 20
20 } 21 }
21 22
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 93
93 scoped_ptr<base::ListValue> entries(log.GetAndClearEntries()); 94 scoped_ptr<base::ListValue> entries(log.GetAndClearEntries());
94 95
95 ASSERT_EQ(2u, entries->GetSize()); 96 ASSERT_EQ(2u, entries->GetSize());
96 ValidateLogEntry(entries.get(), 0, "SEVERE", "severe message"); 97 ValidateLogEntry(entries.get(), 0, "SEVERE", "severe message");
97 ValidateLogEntry(entries.get(), 1, "DEBUG", "debug message"); 98 ValidateLogEntry(entries.get(), 1, "DEBUG", "debug message");
98 } 99 }
99 100
100 TEST(Logging, CreatePerformanceLog) { 101 TEST(Logging, CreatePerformanceLog) {
101 Capabilities capabilities; 102 Capabilities capabilities;
103 Session session("test");
102 capabilities.logging_prefs["performance"] = Log::kInfo; 104 capabilities.logging_prefs["performance"] = Log::kInfo;
103 capabilities.logging_prefs["browser"] = Log::kInfo; 105 capabilities.logging_prefs["browser"] = Log::kInfo;
104 106
105 ScopedVector<DevToolsEventListener> devtools_listeners; 107 ScopedVector<DevToolsEventListener> devtools_listeners;
106 ScopedVector<WebDriverLog> logs; 108 ScopedVector<WebDriverLog> logs;
107 ScopedVector<CommandListener> command_listeners; 109 ScopedVector<CommandListener> command_listeners;
108 Status status = CreateLogs(capabilities, &logs, &devtools_listeners, 110 Status status = CreateLogs(capabilities, &session, &logs, &devtools_listeners,
109 &command_listeners); 111 &command_listeners);
110 ASSERT_TRUE(status.IsOk()); 112 ASSERT_TRUE(status.IsOk());
111 ASSERT_EQ(2u, logs.size()); 113 ASSERT_EQ(2u, logs.size());
112 ASSERT_EQ(2u, devtools_listeners.size()); 114 ASSERT_EQ(2u, devtools_listeners.size());
113 ASSERT_EQ(1u, command_listeners.size()); 115 ASSERT_EQ(1u, command_listeners.size());
114 ASSERT_EQ("performance", logs[0]->type()); 116 ASSERT_EQ("performance", logs[0]->type());
115 ASSERT_EQ("browser", logs[1]->type()); 117 ASSERT_EQ("browser", logs[1]->type());
116 } 118 }
117 119
118 TEST(Logging, IgnoreUnknownLogType) { 120 TEST(Logging, IgnoreUnknownLogType) {
119 Capabilities capabilities; 121 Capabilities capabilities;
122 Session session("test");
120 capabilities.logging_prefs["gaga"] = Log::kInfo; 123 capabilities.logging_prefs["gaga"] = Log::kInfo;
121 124
122 ScopedVector<DevToolsEventListener> devtools_listeners; 125 ScopedVector<DevToolsEventListener> devtools_listeners;
123 ScopedVector<WebDriverLog> logs; 126 ScopedVector<WebDriverLog> logs;
124 ScopedVector<CommandListener> command_listeners; 127 ScopedVector<CommandListener> command_listeners;
125 Status status = CreateLogs(capabilities, &logs, &devtools_listeners, 128 Status status = CreateLogs(capabilities, &session, &logs, &devtools_listeners,
126 &command_listeners); 129 &command_listeners);
127 EXPECT_TRUE(status.IsOk()); 130 EXPECT_TRUE(status.IsOk());
128 ASSERT_EQ(1u, logs.size()); 131 ASSERT_EQ(1u, logs.size());
129 ASSERT_EQ(1u, devtools_listeners.size()); 132 ASSERT_EQ(1u, devtools_listeners.size());
130 ASSERT_EQ(0u, command_listeners.size()); 133 ASSERT_EQ(0u, command_listeners.size());
131 ASSERT_EQ("browser", logs[0]->type()); 134 ASSERT_EQ("browser", logs[0]->type());
132 } 135 }
133 136
134 TEST(Logging, DefaultLogs) { 137 TEST(Logging, DefaultLogs) {
135 Capabilities capabilities; 138 Capabilities capabilities;
139 Session session("test");
136 140
137 ScopedVector<DevToolsEventListener> devtools_listeners; 141 ScopedVector<DevToolsEventListener> devtools_listeners;
138 ScopedVector<WebDriverLog> logs; 142 ScopedVector<WebDriverLog> logs;
139 ScopedVector<CommandListener> command_listeners; 143 ScopedVector<CommandListener> command_listeners;
140 Status status = CreateLogs(capabilities, &logs, &devtools_listeners, 144 Status status = CreateLogs(capabilities, &session, &logs, &devtools_listeners,
141 &command_listeners); 145 &command_listeners);
142 EXPECT_TRUE(status.IsOk()); 146 EXPECT_TRUE(status.IsOk());
143 ASSERT_EQ(1u, logs.size()); 147 ASSERT_EQ(1u, logs.size());
144 ASSERT_EQ(1u, devtools_listeners.size()); 148 ASSERT_EQ(1u, devtools_listeners.size());
145 ASSERT_EQ(0u, command_listeners.size()); 149 ASSERT_EQ(0u, command_listeners.size());
146 ASSERT_EQ("browser", logs[0]->type()); 150 ASSERT_EQ("browser", logs[0]->type());
147 } 151 }
148 152
149 TEST(Logging, GetFirstErrorMessage) { 153 TEST(Logging, GetFirstErrorMessage) {
150 WebDriverLog log(WebDriverLog::kBrowserType, Log::kAll); 154 WebDriverLog log(WebDriverLog::kBrowserType, Log::kAll);
151 std::string entry; 155 std::string entry;
152 156
153 entry = log.GetFirstErrorMessage(); 157 entry = log.GetFirstErrorMessage();
154 ASSERT_TRUE(entry.empty()); 158 ASSERT_TRUE(entry.empty());
155 159
156 log.AddEntry(Log::kInfo, "info message"); 160 log.AddEntry(Log::kInfo, "info message");
157 log.AddEntry(Log::kError, "first error message"); 161 log.AddEntry(Log::kError, "first error message");
158 log.AddEntry(Log::kDebug, "debug message"); 162 log.AddEntry(Log::kDebug, "debug message");
159 log.AddEntry(Log::kError, "second error message"); 163 log.AddEntry(Log::kError, "second error message");
160 164
161 entry = log.GetFirstErrorMessage(); 165 entry = log.GetFirstErrorMessage();
162 ASSERT_EQ("first error message", entry); 166 ASSERT_EQ("first error message", entry);
163 } 167 }
OLDNEW
« no previous file with comments | « chrome/test/chromedriver/logging.cc ('k') | chrome/test/chromedriver/performance_logger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698