Plumbing for using a BBH in SkRecordDraw.

Plumbing for using a BBH in SkRecordDraw.

For now this only creates a degenerate bounding box hierarchy where all ops
just have maximal bounds.  I will flesh out FillBounds in future CL(s).

Not quite sure why QuadTree and TileGrid aren't drawing right---haven't even
looked at the diffs yet---so I've disabled those test modes for now.  RTree
seems fine, so that'll at least get us coverage for all this new plumbing.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/5ad6ee1b2ce54f8e59b9f5a337c688a98a4b0f2a

[mtklein, 2014-08-08 18:58:29]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-08 18:59:35]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/454123003/20001

[commit-bot: I haz the power, 2014-08-08 18:59:36]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-08-09 00:59 UTC

[commit-bot: I haz the power, 2014-08-08 18:59:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 18:59:41]

Presubmit check for 454123003-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.

[reed1, 2014-08-08 19:04:26]

api lgtm

[mtklein, 2014-08-11 14:33:35]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-11 14:34:36]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/454123003/80001

[commit-bot: I haz the power, 2014-08-11 14:38:38]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Try...)
  Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Andr...)

[mtklein, 2014-08-11 14:41:33]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-11 14:42:36]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/454123003/100001

[robertphillips, 2014-08-11 14:45:18]

lgtm + some nits & suggestions

https://codereview.chromium.org/454123003/diff/80001/dm/DMQuiltTask.cpp
File dm/DMQuiltTask.cpp (right):

https://codereview.chromium.org/454123003/diff/80001/dm/DMQuiltTask.cpp#newco...
dm/DMQuiltTask.cpp:17: static const char* kBackends[] = { "default", "skrecord"
};
Add some static asserts here ?

https://codereview.chromium.org/454123003/diff/80001/src/core/SkRecordDraw.cpp
File src/core/SkRecordDraw.cpp (right):

https://codereview.chromium.org/454123003/diff/80001/src/core/SkRecordDraw.cp...
src/core/SkRecordDraw.cpp:35: for (int i = 0; i < ops.count(); i++) {
split "{ return; }" onto separate lines ?

https://codereview.chromium.org/454123003/diff/80001/src/core/SkRecordDraw.cp...
src/core/SkRecordDraw.cpp:41: for (SkRecords::Draw draw(canvas); draw.index() <
record.count(); draw.next()) {
split "{ return; }" onto separate lines ?

https://codereview.chromium.org/454123003/diff/80001/src/core/SkRecordDraw.cp...
src/core/SkRecordDraw.cpp:111: private:
const SkIRect& ?

[mtklein, 2014-08-11 14:47:04]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2014-08-11 14:51:33]

On 2014/08/11 14:45:18, robertphillips wrote:
> lgtm + some nits & suggestions
> 
> https://codereview.chromium.org/454123003/diff/80001/dm/DMQuiltTask.cpp
> File dm/DMQuiltTask.cpp (right):
> 
>
https://codereview.chromium.org/454123003/diff/80001/dm/DMQuiltTask.cpp#newco...
> dm/DMQuiltTask.cpp:17: static const char* kBackends[] = { "default",
"skrecord"
> };
> Add some static asserts here ?
> 
> https://codereview.chromium.org/454123003/diff/80001/src/core/SkRecordDraw.cpp
> File src/core/SkRecordDraw.cpp (right):
> 
>
https://codereview.chromium.org/454123003/diff/80001/src/core/SkRecordDraw.cp...
> src/core/SkRecordDraw.cpp:35: for (int i = 0; i < ops.count(); i++) {
> split "{ return; }" onto separate lines ?
> 
>
https://codereview.chromium.org/454123003/diff/80001/src/core/SkRecordDraw.cp...
> src/core/SkRecordDraw.cpp:41: for (SkRecords::Draw draw(canvas); draw.index()
<
> record.count(); draw.next()) {
> split "{ return; }" onto separate lines ?
> 
>
https://codereview.chromium.org/454123003/diff/80001/src/core/SkRecordDraw.cp...
> src/core/SkRecordDraw.cpp:111: private:
> const SkIRect& ?

All Done.

[mtklein, 2014-08-11 14:51:36]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-11 14:52:36]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/454123003/120001

[commit-bot: I haz the power, 2014-08-11 14:59:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Try...)

[mtklein, 2014-08-11 15:01:58]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-11 15:02:06]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/454123003/140001

[commit-bot: I haz the power, 2014-08-11 15:08:49]

Change committed as 5ad6ee1b2ce54f8e59b9f5a337c688a98a4b0f2a