Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 454073002: Add MinidumpMiscInfoWriter and its test (Closed)

Created:
6 years, 4 months ago by Mark Mentovai
Modified:
6 years, 4 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add MinidumpMiscInfoWriter and its test. TEST=minidump_test MinidumpMiscInfoWriter R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/c73a97d4e39b

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add SCOPED_TRACE for better test diagnostics #

Patch Set 3 : Address review feedback #

Patch Set 4 : Drop unnecessary “using namespace testing” #

Unified diffs Side-by-side diffs Delta from patch set Stats (+966 lines, -5 lines) Patch
M compat/non_win/dbghelp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M minidump/minidump.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
A minidump/minidump_misc_info_writer.h View 1 chunk +105 lines, -0 lines 0 comments Download
A minidump/minidump_misc_info_writer.cc View 1 2 1 chunk +184 lines, -0 lines 0 comments Download
A minidump/minidump_misc_info_writer_test.cc View 1 2 3 1 chunk +659 lines, -0 lines 0 comments Download
M minidump/minidump_string_writer_test.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M minidump/minidump_system_info_writer_test.cc View 1 2 3 4 chunks +12 lines, -0 lines 0 comments Download
M minidump/minidump_writable_test.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Mentovai
6 years, 4 months ago (2014-08-08 16:46:55 UTC) #1
Robert Sesek
https://codereview.chromium.org/454073002/diff/1/minidump/minidump_misc_info_writer.cc File minidump/minidump_misc_info_writer.cc (right): https://codereview.chromium.org/454073002/diff/1/minidump/minidump_misc_info_writer.cc#newcode173 minidump/minidump_misc_info_writer.cc:173: if ((misc_info_.Flags1 & MINIDUMP_MISC3_PROCESS_INTEGRITY) || Why not | the ...
6 years, 4 months ago (2014-08-08 19:29:14 UTC) #2
Mark Mentovai
https://codereview.chromium.org/454073002/diff/1/minidump/minidump_misc_info_writer_test.cc File minidump/minidump_misc_info_writer_test.cc (right): https://codereview.chromium.org/454073002/diff/1/minidump/minidump_misc_info_writer_test.cc#newcode70 minidump/minidump_misc_info_writer_test.cc:70: void ExpectNULPaddedString16Equal(const char16* expected, rsesek wrote: > I suspect ...
6 years, 4 months ago (2014-08-08 22:19:36 UTC) #3
Robert Sesek
LGTM
6 years, 4 months ago (2014-08-11 17:51:57 UTC) #4
Mark Mentovai
6 years, 4 months ago (2014-08-11 18:42:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as c73a97d4e39b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698