minidump/minidump_string_writer_test.cc - Issue 454073002: Add MinidumpMiscInfoWriter and its test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_string_writer_test.cc

Issue 454073002: Add MinidumpMiscInfoWriter and its test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Drop unnecessary “using namespace testing” Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_string_writer_test.cc

diff --git a/minidump/minidump_string_writer_test.cc b/minidump/minidump_string_writer_test.cc

index 3d114f9f24be8b7512c96cda029727df8976050b..682da831f346d4520116d2ff2265b042867581cc 100644

--- a/minidump/minidump_string_writer_test.cc

+++ b/minidump/minidump_string_writer_test.cc

@@ -27,7 +27,6 @@

namespace {

using namespace crashpad;

-using namespace testing;

const MINIDUMP_STRING* MinidumpStringCast(const StringFileWriter& file_writer) {

return reinterpret_cast<const MINIDUMP_STRING*>(&file_writer.string()[0]);