Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1762)

Unified Diff: chrome/browser/extensions/location_bar_controller.cc

Issue 454053005: Consolidate ExtensionToolbarModel::Action and LocationBarController::Action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master for CQ Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/location_bar_controller.cc
diff --git a/chrome/browser/extensions/location_bar_controller.cc b/chrome/browser/extensions/location_bar_controller.cc
index 27eab5ae4692b1bdbc34905f2768c365d777e627..20d925ad4b9debc501d6542ee7508d324d3195c8 100644
--- a/chrome/browser/extensions/location_bar_controller.cc
+++ b/chrome/browser/extensions/location_bar_controller.cc
@@ -6,7 +6,6 @@
#include "base/logging.h"
#include "chrome/browser/extensions/active_script_controller.h"
-#include "chrome/browser/extensions/extension_action.h"
#include "chrome/browser/extensions/page_action_controller.h"
#include "chrome/common/extensions/api/extension_action/action_info.h"
#include "content/public/browser/invalidate_type.h"
@@ -52,24 +51,25 @@ std::vector<ExtensionAction*> LocationBarController::GetCurrentActions() {
return current_actions;
}
-LocationBarController::Action LocationBarController::OnClicked(
+ExtensionAction::ShowAction LocationBarController::OnClicked(
const ExtensionAction* action) {
const Extension* extension =
ExtensionRegistry::Get(web_contents_->GetBrowserContext())
->enabled_extensions().GetByID(action->extension_id());
CHECK(extension) << action->extension_id();
- Action page_action =
+ ExtensionAction::ShowAction page_action =
page_action_controller_->GetActionForExtension(extension) ?
page_action_controller_->OnClicked(extension) :
- ACTION_NONE;
- Action active_script_action =
+ ExtensionAction::ACTION_NONE;
+ ExtensionAction::ShowAction active_script_action =
active_script_controller_->GetActionForExtension(extension) ?
active_script_controller_->OnClicked(extension) :
- ACTION_NONE;
+ ExtensionAction::ACTION_NONE;
// PageAction response takes priority.
- return page_action != ACTION_NONE ? page_action : active_script_action;
+ return page_action != ExtensionAction::ACTION_NONE ? page_action :
+ active_script_action;
}
// static
« no previous file with comments | « chrome/browser/extensions/location_bar_controller.h ('k') | chrome/browser/extensions/page_action_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698