chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc - Issue 453993002: IsCommandIdEnabled should not fall though if the base did handle the command id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc

Issue 453993002: IsCommandIdEnabled should not fall though if the base did handle the command id (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu.cc ('k') | components/renderer_context_menu/render_view_context_menu_base.h » ('j') | components/renderer_context_menu/render_view_context_menu_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc

diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc b/chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc

index ff5c89adb9f6996716894ec5f09be6429ddd19de..52c746f2e2ca97801784250fd2970473523ab7ab 100644

--- a/chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc

+++ b/chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc

@@ -289,3 +289,12 @@ TEST_F(RenderViewContextMenuPrefsTest,

EXPECT_FALSE(

menu->IsCommandIdEnabled(IDC_CONTENT_CONTEXT_OPENLINKOFFTHERECORD));

}

+// Make sure the checking custom command id that is not enabled will not

+// cause DCHECK failure.

+TEST_F(RenderViewContextMenuPrefsTest,

+ IsCustomCommandIdEnabled) {

+ scoped_ptr<TestRenderViewContextMenu> menu(CreateContextMenu());

+ EXPECT_FALSE(menu->IsCommandIdEnabled(IDC_CONTENT_CONTEXT_CUSTOM_FIRST));