IsCommandIdEnabled should not fall though if the base did handle the command id

components/renderer_context_menu/render_view_context_menu_base.h

Index: components/renderer_context_menu/render_view_context_menu_base.h
diff --git a/components/renderer_context_menu/render_view_context_menu_base.h b/components/renderer_context_menu/render_view_context_menu_base.h
index 9d4ac636c0fc38bc8f855d37c2f6ae7ae8604ed3..4a09fa30f37ac4892dadb7331555f2d746f7a713 100644
--- a/components/renderer_context_menu/render_view_context_menu_base.h
+++ b/components/renderer_context_menu/render_view_context_menu_base.h
@@ -78,9 +78,13 @@ class RenderViewContextMenuBase : public ui::SimpleMenuModel::Delegate,
   const ui::SimpleMenuModel& menu_model() const { return menu_model_; }
   const content::ContextMenuParams& params() const { return params_; }
 
+  // Returns true if the specified command id is known and valid for
+  // this menu. If the command is known |enabled| is set to indicate
+  // if the command isenabled.
+  bool GetCommandIdEnabled(int command_id, bool* enabled) const;

[sky, 2014/08/08 19:15:25]

Were you going to rename this to IsCommandIdKnown as I suggested?

[oshima, 2014/08/08 20:42:40]

oops, I missed that part. Done.

+
   // SimpleMenuModel::Delegate implementation.
   virtual bool IsCommandIdChecked(int command_id) const OVERRIDE;
-  virtual bool IsCommandIdEnabled(int command_id) const OVERRIDE;
   virtual void ExecuteCommand(int command_id, int event_flags) OVERRIDE;
   virtual void MenuWillShow(ui::SimpleMenuModel* source) OVERRIDE;
   virtual void MenuClosed(ui::SimpleMenuModel* source) OVERRIDE;