Handle cr.exportPath() in compiler pass, declare every object only once

Handle cr.exportPath() in compiler pass, declare every object only once

BUG=393873
R=dbeam@chromium.org,tbreisacher@chromium.org
TEST=third_party/closure_compiler/runner/how_to_test_compiler_pass.md

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289928

[Vitaly Pavlenko, 2014-08-14 00:04:18]

ping

[Dan Beam, 2014-08-14 02:23:02]

lgtm

https://chromiumcodereview.appspot.com/453783006/diff/1/third_party/closure_c...
File
third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java
(right):

https://chromiumcodereview.appspot.com/453783006/diff/1/third_party/closure_c...
third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java:71:
this.createdObjects = new HashSet<>();
nit: this.createdObjects = new HashSet<>(Arrays.asList("cr"));

https://chromiumcodereview.appspot.com/453783006/diff/1/third_party/closure_c...
third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java:72:
// This variable is declared in ui/webui/resources/js/cr.js
nit: end with .

https://chromiumcodereview.appspot.com/453783006/diff/1/third_party/closure_c...
File
third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java
(right):

https://chromiumcodereview.appspot.com/453783006/diff/1/third_party/closure_c...
third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java:260:
public void testCrDefineAndCrExportPathCreateEveryObjectOnlyOnce() throws
Exception {
Creates

[Vitaly Pavlenko, 2014-08-14 02:40:59]

https://chromiumcodereview.appspot.com/453783006/diff/1/third_party/closure_c...
File
third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java
(right):

https://chromiumcodereview.appspot.com/453783006/diff/1/third_party/closure_c...
third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java:71:
this.createdObjects = new HashSet<>();
On 2014/08/14 02:23:02, Dan Beam wrote:
> nit: this.createdObjects = new HashSet<>(Arrays.asList("cr"));

Done.

https://chromiumcodereview.appspot.com/453783006/diff/1/third_party/closure_c...
third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java:72:
// This variable is declared in ui/webui/resources/js/cr.js
On 2014/08/14 02:23:01, Dan Beam wrote:
> nit: end with .

Done.

https://chromiumcodereview.appspot.com/453783006/diff/1/third_party/closure_c...
File
third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java
(right):

https://chromiumcodereview.appspot.com/453783006/diff/1/third_party/closure_c...
third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java:260:
public void testCrDefineAndCrExportPathCreateEveryObjectOnlyOnce() throws
Exception {
On 2014/08/14 02:23:02, Dan Beam wrote:
> Creates

CrDefine and CrExportPath, so they Create.

[Tyler Breisacher (Chromium), 2014-08-14 17:17:02]

lgtm

[Vitaly Pavlenko, 2014-08-14 17:34:03]

The CQ bit was checked by vitalyp@chromium.org

[commit-bot: I haz the power, 2014-08-14 17:37:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalyp@chromium.org/453783006/40001

[commit-bot: I haz the power, 2014-08-15 00:59:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[commit-bot: I haz the power, 2014-08-15 07:01:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-15 07:01:44]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[Vitaly Pavlenko, 2014-08-15 16:43:07]

The CQ bit was checked by vitalyp@chromium.org

[commit-bot: I haz the power, 2014-08-15 16:43:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalyp@chromium.org/453783006/40001

[commit-bot: I haz the power, 2014-08-15 17:47:25]

Committed patchset #3 (40001) as 289928