Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1567)

Unified Diff: third_party/closure_compiler/compiler_customization_test.py

Issue 453783006: Handle cr.exportPath() in compiler pass, declare every object only once (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@C_define_property
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/closure_compiler/compiler_customization_test.py
diff --git a/third_party/closure_compiler/compiler_customization_test.py b/third_party/closure_compiler/compiler_customization_test.py
index 2e63c6b5ecfeca5a761b190be04ce2b06a67db1c..b15a6b19ed643e8a8a7556bef3b6ca0686e00853 100755
--- a/third_party/closure_compiler/compiler_customization_test.py
+++ b/third_party/closure_compiler/compiler_customization_test.py
@@ -187,6 +187,13 @@ needsNumber(new Class().booleanProp);
""", "ERROR - actual parameter 1 of needsNumber does not match formal "
"parameter")
+ def testCrDefineOnCrWorks(self):
+ self._runCheckerTestExpectSuccess(self._CR_DEFINE_DEFINITION + """
+cr.define('cr', function() {
+ return {};
+});
+""")
+
if __name__ == "__main__":
unittest.main()

Powered by Google App Engine
This is Rietveld 408576698