Issue 453663002: Store client cert hashes as strings instead of StringPieces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 453663002: Store client cert hashes as strings instead of StringPieces. (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)

Modified:
6 years, 4 months ago

Reviewers:
wtc, Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, rjshade

Base URL:
https://chromium.googlesource.com/chromium/src.git@Deprecate_flag_quic_allow_port_migration_72668120

Project:
chromium

Visibility:
Public.

More Reviews

Description

Store client cert hashes as strings instead of StringPieces. Avoids use-after-free (detected by ASAN) when the CHLO callback deletes the CHLO request, and subsequently we try to access the stored StringPieces. Merge internal change: 72724874 Bug introduced in CL: https://codereview.chromium.org/449273002/ R=rch@chromium.org, wtc@chromium.org

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	net/quic/crypto/crypto_handshake.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
	M	net/quic/crypto/quic_crypto_server_config.cc	View		1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages