Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: net/quic/crypto/crypto_handshake.h

Issue 453663002: Store client cert hashes as strings instead of StringPieces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Deprecate_flag_quic_allow_port_migration_72668120
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/quic/crypto/quic_crypto_server_config.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_CRYPTO_CRYPTO_HANDSHAKE_H_ 5 #ifndef NET_QUIC_CRYPTO_CRYPTO_HANDSHAKE_H_
6 #define NET_QUIC_CRYPTO_CRYPTO_HANDSHAKE_H_ 6 #define NET_QUIC_CRYPTO_CRYPTO_HANDSHAKE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/memory/scoped_ptr.h" 11 #include "base/memory/scoped_ptr.h"
12 #include "base/strings/string_piece.h"
13 #include "net/base/net_export.h" 12 #include "net/base/net_export.h"
14 #include "net/quic/quic_protocol.h" 13 #include "net/quic/quic_protocol.h"
15 14
16 namespace net { 15 namespace net {
17 16
18 class CommonCertSets; 17 class CommonCertSets;
19 class KeyExchange; 18 class KeyExchange;
20 class QuicDecrypter; 19 class QuicDecrypter;
21 class QuicEncrypter; 20 class QuicEncrypter;
22 21
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 // channel_id is set by servers to a ChannelID key when the client correctly 122 // channel_id is set by servers to a ChannelID key when the client correctly
124 // proves possession of the corresponding private key. It consists of 32 123 // proves possession of the corresponding private key. It consists of 32
125 // bytes of x coordinate, followed by 32 bytes of y coordinate. Both values 124 // bytes of x coordinate, followed by 32 bytes of y coordinate. Both values
126 // are big-endian and the pair is a P-256 public key. 125 // are big-endian and the pair is a P-256 public key.
127 std::string channel_id; 126 std::string channel_id;
128 127
129 // Used when generating proof signature when sending server config updates. 128 // Used when generating proof signature when sending server config updates.
130 bool x509_ecdsa_supported; 129 bool x509_ecdsa_supported;
131 130
132 // Used to generate cert chain when sending server config updates. 131 // Used to generate cert chain when sending server config updates.
133 base::StringPiece client_common_set_hashes; 132 std::string client_common_set_hashes;
134 base::StringPiece client_cached_cert_hashes; 133 std::string client_cached_cert_hashes;
135 }; 134 };
136 135
137 // QuicCryptoConfig contains common configuration between clients and servers. 136 // QuicCryptoConfig contains common configuration between clients and servers.
138 class NET_EXPORT_PRIVATE QuicCryptoConfig { 137 class NET_EXPORT_PRIVATE QuicCryptoConfig {
139 public: 138 public:
140 // kInitialLabel is a constant that is used when deriving the initial 139 // kInitialLabel is a constant that is used when deriving the initial
141 // (non-forward secure) keys for the connection in order to tie the resulting 140 // (non-forward secure) keys for the connection in order to tie the resulting
142 // key to this protocol. 141 // key to this protocol.
143 static const char kInitialLabel[]; 142 static const char kInitialLabel[];
144 143
(...skipping 17 matching lines...) Expand all
162 161
163 const CommonCertSets* common_cert_sets; 162 const CommonCertSets* common_cert_sets;
164 163
165 private: 164 private:
166 DISALLOW_COPY_AND_ASSIGN(QuicCryptoConfig); 165 DISALLOW_COPY_AND_ASSIGN(QuicCryptoConfig);
167 }; 166 };
168 167
169 } // namespace net 168 } // namespace net
170 169
171 #endif // NET_QUIC_CRYPTO_CRYPTO_HANDSHAKE_H_ 170 #endif // NET_QUIC_CRYPTO_CRYPTO_HANDSHAKE_H_
OLDNEW
« no previous file with comments | « no previous file | net/quic/crypto/quic_crypto_server_config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698