Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 45363004: DevTools: explicitly control support for viewport meta tag so that desktop emulation was possible (Closed)

Created:
7 years, 1 month ago by pfeldman
Modified:
7 years, 1 month ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: explicitly control support for viewport meta tag so that desktop emulation was possible BUG=314361 R=dgozman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161228

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : Same with updated labels #

Total comments: 4

Patch Set 4 : Same w/ text autosize test updated. #

Patch Set 5 : Review comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -49 lines) Patch
M LayoutTests/inspector/styles/override-and-disable.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/styles/override-screen-size.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/text-autosizing-override.html View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 2 3 4 9 chunks +18 lines, -15 lines 0 comments Download
M Source/devtools/front_end/OverridesSupport.js View 4 chunks +4 lines, -1 line 0 comments Download
M Source/devtools/front_end/OverridesView.js View 1 2 5 chunks +17 lines, -4 lines 0 comments Download
M Source/devtools/front_end/Settings.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/InspectorClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/InspectorClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 3 chunks +6 lines, -2 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 3 chunks +31 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pfeldman
Whoever gets this first, PTAL :)
7 years, 1 month ago (2013-11-02 13:06:25 UTC) #1
dgozman
lgtm with nits https://codereview.chromium.org/45363004/diff/20002/Source/core/inspector/InspectorPageAgent.cpp File Source/core/inspector/InspectorPageAgent.cpp (left): https://codereview.chromium.org/45363004/diff/20002/Source/core/inspector/InspectorPageAgent.cpp#oldcode920 Source/core/inspector/InspectorPageAgent.cpp:920: return m_enabled && m_state->getLong(PageAgentState::pageAgentScreenWidthOverride); There are ...
7 years, 1 month ago (2013-11-02 13:27:26 UTC) #2
pfeldman
Thanks for the review! https://codereview.chromium.org/45363004/diff/20002/Source/core/inspector/InspectorPageAgent.cpp File Source/core/inspector/InspectorPageAgent.cpp (left): https://codereview.chromium.org/45363004/diff/20002/Source/core/inspector/InspectorPageAgent.cpp#oldcode920 Source/core/inspector/InspectorPageAgent.cpp:920: return m_enabled && m_state->getLong(PageAgentState::pageAgentScreenWidthOverride); On ...
7 years, 1 month ago (2013-11-02 13:31:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/45363004/120001
7 years, 1 month ago (2013-11-02 13:31:42 UTC) #4
pfeldman
7 years, 1 month ago (2013-11-02 14:09:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r161228 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698