Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Unified Diff: Source/devtools/front_end/OverridesSupport.js

Issue 45363004: DevTools: explicitly control support for viewport meta tag so that desktop emulation was possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review comments addressed. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorPageAgent.cpp ('k') | Source/devtools/front_end/OverridesView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/OverridesSupport.js
diff --git a/Source/devtools/front_end/OverridesSupport.js b/Source/devtools/front_end/OverridesSupport.js
index 228d826010616408479c463bd8faea9284ed683d..e4d4edec802aa4aebcb4e164d4387b9e16591bcf 100644
--- a/Source/devtools/front_end/OverridesSupport.js
+++ b/Source/devtools/front_end/OverridesSupport.js
@@ -42,6 +42,7 @@ WebInspector.OverridesSupport = function()
WebInspector.settings.overrideDeviceMetrics.addChangeListener(this._deviceMetricsChanged, this);
WebInspector.settings.deviceMetrics.addChangeListener(this._deviceMetricsChanged, this);
+ WebInspector.settings.emulateViewport.addChangeListener(this._deviceMetricsChanged, this);
WebInspector.settings.deviceFitWindow.addChangeListener(this._deviceMetricsChanged, this);
WebInspector.settings.overrideGeolocation.addChangeListener(this._geolocationPositionChanged, this);
@@ -409,6 +410,7 @@ WebInspector.OverridesSupport.prototype = {
WebInspector.settings.overrideDeviceMetrics.set(true);
WebInspector.settings.overrideUserAgent.set(true);
WebInspector.settings.emulateTouchEvents.set(true);
+ WebInspector.settings.emulateViewport.set(true);
},
reset: function()
@@ -419,6 +421,7 @@ WebInspector.OverridesSupport.prototype = {
WebInspector.settings.overrideDeviceOrientation.set(false);
WebInspector.settings.overrideGeolocation.set(false);
WebInspector.settings.overrideCSSMedia.set(false);
+ WebInspector.settings.emulateViewport.set(false);
},
applyInitialOverrides: function()
@@ -452,7 +455,7 @@ WebInspector.OverridesSupport.prototype = {
var active = metrics.width > 0 && metrics.height > 0;
var dipWidth = Math.round(metrics.width / metrics.deviceScaleFactor);
var dipHeight = Math.round(metrics.height / metrics.deviceScaleFactor);
- PageAgent.setDeviceMetricsOverride(dipWidth, dipHeight, metrics.deviceScaleFactor, WebInspector.settings.deviceFitWindow.get(), metrics.textAutosizing, metrics.fontScaleFactor);
+ PageAgent.setDeviceMetricsOverride(dipWidth, dipHeight, metrics.deviceScaleFactor, WebInspector.settings.emulateViewport.get(), WebInspector.settings.deviceFitWindow.get(), metrics.textAutosizing, metrics.fontScaleFactor);
}
this._revealOverridesTabIfNeeded();
this.dispatchEventToListeners(WebInspector.OverridesSupport.Events.OverridesEnabledButImpossibleChanged);
« no previous file with comments | « Source/core/inspector/InspectorPageAgent.cpp ('k') | Source/devtools/front_end/OverridesView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698