Improve detection of touch events when hiding media controls.

Source/platform/PlatformMouseEvent.h

Index: Source/platform/PlatformMouseEvent.h
diff --git a/Source/platform/PlatformMouseEvent.h b/Source/platform/PlatformMouseEvent.h
index 4a4b8a95ee4539a6f39e03ce151b885fb093e07c..110f2d07ade55baf6082c92d8ad4e1a213c72db1 100644
--- a/Source/platform/PlatformMouseEvent.h
+++ b/Source/platform/PlatformMouseEvent.h
@@ -37,15 +37,16 @@ enum MouseButton { NoButton = -1, LeftButton, MiddleButton, RightButton };
 class PlatformMouseEvent : public PlatformEvent {
 public:
     enum SyntheticEventType {
-        NotFromTouch,
-        FromTouch,
+        NotSyntheticOrIndistinguishable, // Real mouse input events or synthetic events that behave just like real events

[Rick Byers, 2014/08/22 18:11:13]

nit: maybe put these comments on the line above the value - we don't want to
discourage long comments here, if we need multiple lines that's fine.

[Rick Byers, 2014/08/22 18:11:13]

nit: this name is a bit of a mouthful.  I like that you're explicit that they
may still be synthetic though.  Maybe "RealOrIndistinguishable" would be a
little clearer?

[Ignacio Solla, 2014/08/26 13:40:53]

Done.

[Ignacio Solla, 2014/08/26 13:40:53]

I agree, it is a mouthful, I've changed it now to RealOrIndistinguishable.

FYI, I was on the verge, but had decided to use not synthetic because:
- synthetic is a more precise term than real
- one could argue that synthetic events are also real.

+        FromTouch, // Mouse events derived from touch input
+        NotFromInput, // Blink can generate fake mouse events after scrolling or re-layout, see for example EventHandler::dispatchFakeMouseMoveEventSoon
     };
 
     PlatformMouseEvent()
         : PlatformEvent(PlatformEvent::MouseMoved)
         , m_button(NoButton)
         , m_clickCount(0)
-        , m_synthesized(NotFromTouch)
+        , m_synthesized(NotSyntheticOrIndistinguishable)
         , m_modifierFlags(0)
     {
     }
@@ -56,7 +57,7 @@ public:
         , m_globalPosition(globalPosition)
         , m_button(button)
         , m_clickCount(clickCount)
-        , m_synthesized(NotFromTouch)
+        , m_synthesized(NotSyntheticOrIndistinguishable)
         , m_modifierFlags(0)
     {
     }
@@ -72,13 +73,13 @@ public:
     {
     }
 
-    PlatformMouseEvent(const IntPoint& position, const IntPoint& globalPosition, MouseButton button, PlatformEvent::Type type, int clickCount, bool shiftKey, bool ctrlKey, bool altKey, bool metaKey, double timestamp)
+    PlatformMouseEvent(const IntPoint& position, const IntPoint& globalPosition, MouseButton button, PlatformEvent::Type type, int clickCount, bool shiftKey, bool ctrlKey, bool altKey, bool metaKey, double timestamp, SyntheticEventType synthesized = NotSyntheticOrIndistinguishable)

[Rick Byers, 2014/08/22 18:11:13]

I think we should try to keep the parameter order consistent (synthesized comes
before timestamp in the above version).  We also tend to avoid default argument
values (although I don't think they're prohibited outright like in the chromium
style guide).  I guess that means either add but-yet-another overload, or update
the handful of callers (eclipse finds 16 for me including tests).

[Ignacio Solla, 2014/08/26 13:40:53]

Done. 

Added a non-optional arg and updated all callers.

[Rick Byers, 2014/08/26 15:25:46]

Thank you!

[Ignacio Solla, 2014/08/26 17:30:42]

Acknowledged.

         : PlatformEvent(type, shiftKey, ctrlKey, altKey, metaKey, timestamp)
         , m_position(position)
         , m_globalPosition(globalPosition)
         , m_button(button)
         , m_clickCount(clickCount)
-        , m_synthesized(NotFromTouch)
+        , m_synthesized(synthesized)
         , m_modifierFlags(0)
     {
     }
@@ -91,6 +92,7 @@ public:
     int clickCount() const { return m_clickCount; }
     unsigned modifierFlags() const { return m_modifierFlags; }
     bool fromTouch() const { return m_synthesized == FromTouch; }
+    SyntheticEventType syntheticEventType() const { return m_synthesized; }
 
 protected:
     IntPoint m_position;