Source/core/page/EventHandler.cpp - Issue 453493002: Improve detection of touch events when hiding media controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventHandler.cpp

Issue 453493002: Improve detection of touch events when hiding media controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@autoHideControls

Patch Set: Added multimodal tests and NotFromInput synthetic type. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/shadow/MediaControls.cpp ('K') | « Source/core/html/shadow/MediaControls.cpp ('k') | Source/platform/PlatformMouseEvent.h » ('j') | Source/platform/PlatformMouseEvent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/EventHandler.cpp

diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp

index 05663c09738673aaa0d6aae6bd7cb55572b475a8..f07e64e4fac270fc947b37f19ded17c05ba3fc3b 100644

--- a/Source/core/page/EventHandler.cpp

+++ b/Source/core/page/EventHandler.cpp

@@ -2865,7 +2865,7 @@ void EventHandler::fakeMouseMoveEventTimerFired(Timer<EventHandler>* timer)

bool altKey;

bool metaKey;

PlatformKeyboardEvent::getCurrentModifierState(shiftKey, ctrlKey, altKey, metaKey);

- PlatformMouseEvent fakeMouseMoveEvent(m_lastKnownMousePosition, m_lastKnownMouseGlobalPosition, NoButton, PlatformEvent::MouseMoved, 0, shiftKey, ctrlKey, altKey, metaKey, currentTime());

+ PlatformMouseEvent fakeMouseMoveEvent(m_lastKnownMousePosition, m_lastKnownMouseGlobalPosition, NoButton, PlatformEvent::MouseMoved, 0, shiftKey, ctrlKey, altKey, metaKey, currentTime(), PlatformMouseEvent::NotFromInput);

handleMouseMoveEvent(fakeMouseMoveEvent);

}

« Source/core/html/shadow/MediaControls.cpp ('K') | « Source/core/html/shadow/MediaControls.cpp ('k') | Source/platform/PlatformMouseEvent.h » ('j') | Source/platform/PlatformMouseEvent.h » ('J')