Improve detection of touch events when hiding media controls.

LayoutTests/media/video-controls-visibility-multimodal-touch-after-mouse.html

Index: LayoutTests/media/video-controls-visibility-multimodal-touch-after-mouse.html
diff --git a/LayoutTests/media/video-controls-hide-after-touch-on-control.html b/LayoutTests/media/video-controls-visibility-multimodal-touch-after-mouse.html
similarity index 65%
copy from LayoutTests/media/video-controls-hide-after-touch-on-control.html
copy to LayoutTests/media/video-controls-visibility-multimodal-touch-after-mouse.html
index 7715602593f57267742396af3b1e56fa46035fd3..fc625eb0099b08ff89a8cde653c67f43ed9e5f76 100644
--- a/LayoutTests/media/video-controls-hide-after-touch-on-control.html
+++ b/LayoutTests/media/video-controls-visibility-multimodal-touch-after-mouse.html
@@ -20,33 +20,31 @@ function runTest()
     if (!window.testRunner)
         return;
 
-    // Click the play button.
-    var playCoords = mediaControlsButtonCoordinates(video, "play-button");
-    var clickX = playCoords[0];
-    var clickY = playCoords[1];
-    eventSender.mouseMoveTo(clickX, clickY);
-    eventSender.mouseDown();
-    eventSender.mouseUp();
+    // Hover the control with the mouse.
+    var coords = mediaControlsButtonCoordinates(video, "play-button");
+    eventSender.mouseMoveTo(coords[0], coords[1]);
+    
+    // And then tap (touch input) the play button.
+    eventSender.gestureTap(coords[0], coords[1]);
     testExpected("video.paused", false);
 
+    // And the controls should hide after a timeout.

[Ignacio Solla, 2014/08/21 17:42:31]

BTW, this is the test that failed before I added NotFromInput.

This is why:
1. The timer to hide the controls fires
2. The controls become hidden
3. The layout changes and blink generates fake mouse events
4. MediaControls receives the fake mouse events and makes the controls visible
again

The solution is to detect that the events are fake at 4, and do not make them
visible.

[Rick Byers, 2014/08/22 18:11:13]

Nice, good catch!

Do you really never want to consider these timer-based events though?  Eg. the
user moving their mouse over the control area should show the controls.  What if
(on a desktop with just a mouse) the user drags the window such that the control
area is now under the mouse cursor?  Or what if the page layout changes and
moves the video so it's under the mouse cursor?

In general we treat relative movement between the content and mouse cursor as
the same thing - regardless of which is actually moving in an absolute sense.

But maybe it makes sense in this case to care only about physical mouse input -
I can see an argument for that.

In the real world you shouldn't actually hit this case because when the user
does a tap on the touchscreen we hide the mouse cursor, which will later result
in an early-out from EventHandler::fakeMouseMoveEventTimerFired due to the
isCursorVisible check.

So another option is to just update your test to cause isCursorVisible to be set
false after the tap.

[Ignacio Solla, 2014/08/26 13:40:53]

Done.

I have added the internals.setCursorVisible to false now and removed the
NotFromInput synthetic value. In real life (I have tested with Android) I can
see that the cursor gets hidden after a tap. Do you know why we need to hide
manually in the test? Is it because the test eventSender executes a slightly
different path?

[Ignacio Solla, 2014/08/26 13:40:53]

Acknowledged.

[Rick Byers, 2014/08/26 15:25:46]

Yeah, LayoutTests are really designed just test blink, so eventSender just
injects events into blink.  That logic lives in chromium.  To test that
end-to-end you'd have to write a browsertest (and cross blink/browser async
behavior is notoriously difficult to reliably test with browser tests).

By the way, I just did a quick search and it looks to me like only Aura informs
blink of the cursor visibility (that's the only call I see to
RenderWidgetHostImpl::SendCursorVisibilityState).  So and edge case probably
remains on Android here.  Feel free to file a bug to me for getting
SendCusrorVisibilityState implemented on Android (mouse scenarios on Android
aren't well covered).

[Ignacio Solla, 2014/08/26 17:30:42]

I had manually tested with Android and a keyboard, and the cursor does also
become invisible after touch. I'm not sure what the code path is though.

     runAfterHideMediaControlsTimerFired(function()
     {
         controls = mediaControlsButton(video, "panel");
         testExpected("getComputedStyle(controls).opacity", 0);
-
-        consoleWrite("");
         endTest();
     }, video);
+    
 }
 </script>
 <body>
-    <p>Test video element control visibility after touch on control. After a delay the
-       controls must be hidden.</p>
+    <p>Test video element control visibility with multimodal input. The controls
+       should hide after a timeout if the last input event was a tap.</p>
     <p>This test only runs in DRT!</p>
 
     <video id="no-video-media" controls loop oncanplaythrough="runTest()"></video>
     <script>
-        window.internals.settings.setDeviceSupportsMouse(false);
         setSrcById("no-video-media", findMediaFile("video", "content/test"));
     </script>
 </body>