LayoutTests/media/video-controls-hide-after-touch-on-control.html - Issue 453493002: Improve detection of touch events when hiding media controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/media/video-controls-hide-after-touch-on-control.html

Issue 453493002: Improve detection of touch events when hiding media controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@autoHideControls

Patch Set: Added multimodal tests and NotFromInput synthetic type. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html » ('j') | LayoutTests/media/video-controls-visibility-multimodal-touch-after-mouse.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/media/video-controls-hide-after-touch-on-control.html

diff --git a/LayoutTests/media/video-controls-hide-after-touch-on-control.html b/LayoutTests/media/video-controls-hide-after-touch-on-control.html

index 7715602593f57267742396af3b1e56fa46035fd3..e5f4aed67d7abb02a59b33a4886673e81443397b 100644

--- a/LayoutTests/media/video-controls-hide-after-touch-on-control.html

+++ b/LayoutTests/media/video-controls-hide-after-touch-on-control.html

@@ -20,13 +20,9 @@ function runTest()

if (!window.testRunner)

return;

- // Click the play button.

- var playCoords = mediaControlsButtonCoordinates(video, "play-button");

- var clickX = playCoords[0];

- var clickY = playCoords[1];

- eventSender.mouseMoveTo(clickX, clickY);

- eventSender.mouseDown();

- eventSender.mouseUp();

+ // Tap the play button

+ var coords = mediaControlsButtonCoordinates(video, "play-button");

+ eventSender.gestureTap(coords[0], coords[1]);

Rick Byers 2014/08/22 18:11:13 for maximum fidelity with how touch actually behav

Ignacio Solla 2014/08/26 13:40:53 Done.

testExpected("video.paused", false);

runAfterHideMediaControlsTimerFired(function()

@@ -46,7 +42,6 @@ function runTest()

- window.internals.settings.setDeviceSupportsMouse(false);

setSrcById("no-video-media", findMediaFile("video", "content/test"));

</script>

</body>