Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: LayoutTests/media/video-controls-hide-after-touch-on-control.html

Issue 453493002: Improve detection of touch events when hiding media controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@autoHideControls
Patch Set: Added multimodal tests and NotFromInput synthetic type. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/media/video-controls-hide-after-touch-on-control.html
diff --git a/LayoutTests/media/video-controls-hide-after-touch-on-control.html b/LayoutTests/media/video-controls-hide-after-touch-on-control.html
index 7715602593f57267742396af3b1e56fa46035fd3..e5f4aed67d7abb02a59b33a4886673e81443397b 100644
--- a/LayoutTests/media/video-controls-hide-after-touch-on-control.html
+++ b/LayoutTests/media/video-controls-hide-after-touch-on-control.html
@@ -20,13 +20,9 @@ function runTest()
if (!window.testRunner)
return;
- // Click the play button.
- var playCoords = mediaControlsButtonCoordinates(video, "play-button");
- var clickX = playCoords[0];
- var clickY = playCoords[1];
- eventSender.mouseMoveTo(clickX, clickY);
- eventSender.mouseDown();
- eventSender.mouseUp();
+ // Tap the play button
+ var coords = mediaControlsButtonCoordinates(video, "play-button");
+ eventSender.gestureTap(coords[0], coords[1]);
Rick Byers 2014/08/22 18:11:13 for maximum fidelity with how touch actually behav
Ignacio Solla 2014/08/26 13:40:53 Done.
testExpected("video.paused", false);
runAfterHideMediaControlsTimerFired(function()
@@ -46,7 +42,6 @@ function runTest()
<video id="no-video-media" controls loop oncanplaythrough="runTest()"></video>
<script>
- window.internals.settings.setDeviceSupportsMouse(false);
setSrcById("no-video-media", findMediaFile("video", "content/test"));
</script>
</body>

Powered by Google App Engine
This is Rietveld 408576698