Improve detection of touch events when hiding media controls.

Source/core/events/MouseEvent.h

Index: Source/core/events/MouseEvent.h
diff --git a/Source/core/events/MouseEvent.h b/Source/core/events/MouseEvent.h
index 3bb4298f81c9ae39854e77c07e001963e78b23cf..4f45a328684b345b4d2fb48dffe86fefbd6a8402 100644
--- a/Source/core/events/MouseEvent.h
+++ b/Source/core/events/MouseEvent.h
@@ -59,7 +59,8 @@ public:
         int detail, int screenX, int screenY, int pageX, int pageY,
         int movementX, int movementY,
         bool ctrlKey, bool altKey, bool shiftKey, bool metaKey, unsigned short button,
-        PassRefPtrWillBeRawPtr<EventTarget> relatedTarget, PassRefPtrWillBeRawPtr<DataTransfer>, bool isSimulated = false);
+        PassRefPtrWillBeRawPtr<EventTarget> relatedTarget, PassRefPtrWillBeRawPtr<DataTransfer>,
+        bool isSimulated = false, PlatformMouseEvent::SyntheticEventType = PlatformMouseEvent::NotFromTouch);

[Rick Byers, 2014/08/20 23:32:56]

Re-using the PlatformMouseEvent::SyntheticEventType enum is fine with me.  As
far as I'm concerned the platform/core abstraction layer around events isn't
worth the extra complexity.

I looked into the isSimulated stuff.  Looks like it's used just for
Element.dispatchSimulatedClick.  I don't understand though why it isn't just a
virtual method that results false but is overriden by SimulatedMouseEvent.

I think having both "simulated" and "synthetic" is a little confusing.  Ideally
we'd collapse them into the enum and add another value called "simulated" that
is defined not to carry any position information (that's really what makes these
events special).  If you don't want to do that refactoring now, feel free to add
a FIXME and comment somewhere that at least describes the difference between
"simulated" and "synthetic".

[Ignacio Solla, 2014/08/21 17:30:14]

Yes, I completely agree that isSimulated should be collapse into the
SyntheticEventType enum. I have added the FIXME and filed crbug/405990

 
     static PassRefPtrWillBeRawPtr<MouseEvent> create(const AtomicString& eventType, PassRefPtrWillBeRawPtr<AbstractView>, const PlatformMouseEvent&, int detail, PassRefPtrWillBeRawPtr<Node> relatedTarget);
 
@@ -97,7 +98,8 @@ protected:
         int detail, int screenX, int screenY, int pageX, int pageY,
         int movementX, int movementY,
         bool ctrlKey, bool altKey, bool shiftKey, bool metaKey, unsigned short button,
-        PassRefPtrWillBeRawPtr<EventTarget> relatedTarget, PassRefPtrWillBeRawPtr<DataTransfer>, bool isSimulated);
+        PassRefPtrWillBeRawPtr<EventTarget> relatedTarget, PassRefPtrWillBeRawPtr<DataTransfer>,
+        bool isSimulated, PlatformMouseEvent::SyntheticEventType);
 
     MouseEvent(const AtomicString& type, const MouseEventInit&);