Source/core/page/EventHandler.cpp - Issue 453493002: Improve detection of touch events when hiding media controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventHandler.cpp

Issue 453493002: Improve detection of touch events when hiding media controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@autoHideControls

Patch Set: Propagate SyntheticEventType to MouseRelatedEvent Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/EventHandler.cpp

diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp

index b2e91147ce635d4132727b17ed825571bf86d053..6391557b9882fa92394597ecb399a85967b1228c 100644

--- a/Source/core/page/EventHandler.cpp

+++ b/Source/core/page/EventHandler.cpp

@@ -1870,7 +1870,7 @@ void EventHandler::updateMouseEventTargetNode(Node* targetNode, const PlatformMo

bool EventHandler::dispatchMouseEvent(const AtomicString& eventType, Node* targetNode, int clickCount, const PlatformMouseEvent& mouseEvent, bool setUnder)

{

updateMouseEventTargetNode(targetNode, mouseEvent, setUnder);

- return !m_nodeUnderMouse || m_nodeUnderMouse->dispatchMouseEvent(mouseEvent, eventType, clickCount);

+ return !m_nodeUnderMouse || m_nodeUnderMouse->dispatchMouseEvent(mouseEvent, eventType, clickCount, 0);

Rick Byers 2014/08/20 23:32:56 What's this for?

Ignacio Solla 2014/08/21 17:30:14 Left-over from previous patch version.

}

// The return value means 'swallow event' (was handled), as for other handle* functions.

« Source/core/events/MouseEvent.h ('K') | « Source/core/html/shadow/MediaControls.cpp ('k') | Source/platform/PlatformMouseEvent.h » ('j') | no next file with comments »