rebaseline_server: allow live queries to examine JSONKEY_EXPECTEDRESULTS or JSONKEY_ACTUALRESULTS

rebaseline_server: allow live queries to examine JSONKEY_EXPECTEDRESULTS or JSONKEY_ACTUALRESULTS

See https://goto.google.com/CorrectnessTestingBigIssues for full context

BUG=skia:1942
NOTRY=true

Committed: https://skia.googlesource.com/skia/+/e73cd5ab0f693ae0c81f5f1ca76045363b6f999d

[epoger, 2014-08-07 17:27:36]

Ravi/Stephan: PTAL as of patchset 2.

You can try it out on my running server:

http://172.24.179.183:8888/static/live-view.html#/live-view.html?urlSchemaVer...

https://codereview.chromium.org/453433004/diff/20001/gm/rebaseline_server/com...
File gm/rebaseline_server/compare_rendered_pictures.py (right):

https://codereview.chromium.org/453433004/diff/20001/gm/rebaseline_server/com...
gm/rebaseline_server/compare_rendered_pictures.py:76: setA_dirs, setB_dirs,
Added some extra linefeeds here to visually group the parameters.  Let me know
if you find this offensive.

https://codereview.chromium.org/453433004/diff/20001/gm/rebaseline_server/com...
gm/rebaseline_server/compare_rendered_pictures.py:248: if tiled_images_A or
tiled_images_B:
Made these changes so that empty expectations show up as lots of no-comparison
results, not a completely blank list.

[rmistry, 2014-08-07 18:57:06]

LGTM

https://codereview.chromium.org/453433004/diff/20001/gm/rebaseline_server/com...
File gm/rebaseline_server/compare_rendered_pictures.py (right):

https://codereview.chromium.org/453433004/diff/20001/gm/rebaseline_server/com...
gm/rebaseline_server/compare_rendered_pictures.py:76: setA_dirs, setB_dirs,
On 2014/08/07 17:27:36, epoger wrote:
> Added some extra linefeeds here to visually group the parameters.  Let me know
> if you find this offensive.

makes sense to me.

https://codereview.chromium.org/453433004/diff/20001/gm/rebaseline_server/com...
gm/rebaseline_server/compare_rendered_pictures.py:248: if tiled_images_A or
tiled_images_B:
On 2014/08/07 17:27:36, epoger wrote:
> Made these changes so that empty expectations show up as lots of no-comparison
> results, not a completely blank list.

Acknowledged.

https://codereview.chromium.org/453433004/diff/20001/gm/rebaseline_server/com...
File gm/rebaseline_server/compare_rendered_pictures_test.py (right):

https://codereview.chromium.org/453433004/diff/20001/gm/rebaseline_server/com...
gm/rebaseline_server/compare_rendered_pictures_test.py:79:
setB_dirs=[posixpath.join(base_repo_url, 'actuals')],
Side question: about the posixpath.joins, the rebaseline server is not meant to
be run on windows?

[epoger, 2014-08-07 19:03:18]

Thanks. Will commit shortly, along with
https://codereview.chromium.org/446373003/ ('adjust prefetch URL we hit in
UploadRenderedSKPs, and display view URL in CompareRenderedSKPs')

https://codereview.chromium.org/453433004/diff/20001/gm/rebaseline_server/com...
File gm/rebaseline_server/compare_rendered_pictures_test.py (right):

https://codereview.chromium.org/453433004/diff/20001/gm/rebaseline_server/com...
gm/rebaseline_server/compare_rendered_pictures_test.py:79:
setB_dirs=[posixpath.join(base_repo_url, 'actuals')],
On 2014/08/07 18:57:05, rmistry wrote:
> Side question: about the posixpath.joins, the rebaseline server is not meant
to
> be run on windows?

It should work on Windows (not that I've tried it).

The repo_urls are treated like any URL--they use posixpath forward-slashes.

[epoger, 2014-08-07 19:11:36]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-08-07 19:12:02]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/epoger@google.com/453433004/20001

[commit-bot: I haz the power, 2014-08-07 19:13:19]

Change committed as e73cd5ab0f693ae0c81f5f1ca76045363b6f999d