Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: gm/rebaseline_server/static/live-loader.js

Issue 453433004: rebaseline_server: allow live queries to examine JSONKEY_EXPECTEDRESULTS or JSONKEY_ACTUALRESULTS (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: create ALLOWED_SECTION_NAMES Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gm/rebaseline_server/static/live-loader.js
diff --git a/gm/rebaseline_server/static/live-loader.js b/gm/rebaseline_server/static/live-loader.js
index f171ff0fe91331c200c6264e791acc6505cb4759..00800682f309c70c7df9cfcf4ab15be2d95d14e7 100644
--- a/gm/rebaseline_server/static/live-loader.js
+++ b/gm/rebaseline_server/static/live-loader.js
@@ -128,7 +128,9 @@ Loader.controller(
$scope.constants = constants;
$scope.windowTitle = "Loading GM Results...";
$scope.setADir = $location.search().setADir;
+ $scope.setASection = $location.search().setASection;
$scope.setBDir = $location.search().setBDir;
+ $scope.setBSection = $location.search().setBSection;
$scope.loadingMessage = "please wait...";
/**
@@ -138,7 +140,9 @@ Loader.controller(
*/
var liveQueryUrl =
"/live-results/setADir=" + encodeURIComponent($scope.setADir) +
- "&setBDir=" + encodeURIComponent($scope.setBDir);
+ "&setASection=" + encodeURIComponent($scope.setASection) +
+ "&setBDir=" + encodeURIComponent($scope.setBDir) +
+ "&setBSection=" + encodeURIComponent($scope.setBSection);
$http.get(liveQueryUrl).success(
function(data, status, header, config) {
var dataHeader = data[constants.KEY__ROOT__HEADER];
@@ -252,7 +256,9 @@ Loader.controller(
// parameter name -> copier object to load/save parameter value
$scope.queryParameters.map = {
'setADir': $scope.queryParameters.copiers.simple,
+ 'setASection': $scope.queryParameters.copiers.simple,
'setBDir': $scope.queryParameters.copiers.simple,
+ 'setBSection': $scope.queryParameters.copiers.simple,
'displayLimitPending': $scope.queryParameters.copiers.simple,
'showThumbnailsPending': $scope.queryParameters.copiers.simple,
'mergeIdenticalRowsPending': $scope.queryParameters.copiers.simple,

Powered by Google App Engine
This is Rietveld 408576698