Issue 453203003: Introduce DEFINE_CUSTOM_FONT_DATA_TYPE_CASTS, and use it

Issue 453203003: Introduce DEFINE_CUSTOM_FONT_DATA_TYPE_CASTS, and use it (Closed)

Created:
6 years, 4 months ago by gyuyoung-inactive

Modified:
6 years, 4 months ago

Reviewers:
tkent

CC:
blink-reviews, eae+blinkwatch, fs, apavlov+blink_chromium.org, kouhei+svg_chromium.org, rune+blink, jamesr, krit, blink-reviews-css, danakj, dglazkov+blink, Rik, jchaffraix+rendering, pdr., rwlbuis, zoltan1, jbroman, gyuyoung.kim_webkit.org, darktears, blink-reviews-rendering, leviw+renderwatch, ed+blinkwatch_opera.com, f(malita), Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Introduce DEFINE_CUSTOM_FONT_DATA_TYPE_CASTS, and use it As a step to use toFoo, this cl introduces DEFINE_CUSTOM_FONT_DATA_TYPE_CASTS, and use it. Additionally this cl clean up static_cast<TextCloneCSSValue*> with toTextCloneCSSValue(). BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179898

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -5 lines)			Patch
M	Source/core/css/CSSValue.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/svg/SVGTextLayoutEngineSpacing.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/rendering/svg/SVGTextRunRenderingContext.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGFontData.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/platform/fonts/CustomFontData.h	View	1 chunk	+4 lines, -0 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tkent

lgtm https://codereview.chromium.org/453203003/diff/1/Source/platform/fonts/CustomFontData.h File Source/platform/fonts/CustomFontData.h (right): https://codereview.chromium.org/453203003/diff/1/Source/platform/fonts/CustomFontData.h#newcode59 Source/platform/fonts/CustomFontData.h:59: #define DEFINE_CUSTOM_FONT_DATA_TYPE_CASTS(thisType, predicate) \ I feel introducing new ...

6 years, 4 months ago (2014-08-11 01:04:56 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/453203003/1

6 years, 4 months ago (2014-08-11 01:05:21 UTC) #3

gyuyoung-inactive

6 years, 4 months ago (2014-08-11 04:50:56 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/453203003/diff/1/Source/platform/fonts/Custom...
File Source/platform/fonts/CustomFontData.h (right):

https://codereview.chromium.org/453203003/diff/1/Source/platform/fonts/Custom...
Source/platform/fonts/CustomFontData.h:59: #define
DEFINE_CUSTOM_FONT_DATA_TYPE_CASTS(thisType, predicate) \
On 2014/08/11 01:04:56, tkent wrote:
> I feel introducing new macro only for SVGFontData is overkill.  But it's ok.

If there is only SVGFontData as child class of CustomFontData class, I didn't
use this. But, there are two more child classes(CSSCustomFontData and
TestCustomFontData) though they don't use type casting yet. So, I add new macro
so that those classes also will use this macro in future.

Expand Messages | Collapse Messages