Source/core/rendering/svg/SVGTextRunRenderingContext.cpp - Issue 453203003: Introduce DEFINE_CUSTOM_FONT_DATA_TYPE_CASTS, and use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

Issue 453203003: Introduce DEFINE_CUSTOM_FONT_DATA_TYPE_CASTS, and use it (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

diff --git a/Source/core/rendering/svg/SVGTextRunRenderingContext.cpp b/Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

index b858cbd7014ae9a0071b0788bc6d5d11ace1df80..2fd85e157e7d9f60f8d18bb46056d108fde37498 100644

--- a/Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

+++ b/Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

@@ -43,7 +43,7 @@ static inline const SVGFontData* svgFontAndFontFaceElementForFontData(const Simp

ASSERT(fontData->isSVGFont());

RefPtr<CustomFontData> customFontData = fontData->customFontData();

- const SVGFontData* svgFontData = static_cast<const SVGFontData*>(customFontData.get());

+ const SVGFontData* svgFontData = toSVGFontData(customFontData);

// FIXME crbug.com/359380 : The current editing impl references the font after the svg font nodes are removed.

if (svgFontData->shouldSkipDrawing())

« no previous file with comments | « Source/core/rendering/svg/SVGTextLayoutEngineSpacing.cpp ('k') | Source/core/svg/SVGFontData.h » ('j') | Source/platform/fonts/CustomFontData.h » ('J')