RenderLayer::hasVisibleContent should ASSERT(!m_visibleContentStatusDirty)

RenderLayer::hasVisibleContent should ASSERT(!m_visibleContentStatusDirty)

This CL makes RenderLayer::hasVisibleContent ASSERT that the state it reads
isn't dirty. This CL also fixes a couple callers that were reading the state
while it was dirty.

R=skobes@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179990

[skobes, 2014-08-08 21:59:42]

lgtm

https://codereview.chromium.org/453113002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderLayer.h (right):

https://codereview.chromium.org/453113002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderLayer.h:174: // FIXME: hasVisibleDescendant() should
call updateDescendantDependentFlags() if m_visibleContentStatusDirty.
hasVisibleDescendant -> hasVisibleContent

[abarth-chromium, 2014-08-08 22:17:56]

Done

[abarth-chromium, 2014-08-08 22:17:58]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-08-08 22:18:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/453113002/20001

[commit-bot: I haz the power, 2014-08-08 23:22:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19094)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/21843)

[commit-bot: I haz the power, 2014-08-08 23:49:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 23:49:47]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[abarth-chromium, 2014-08-09 17:31:15]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-08-09 17:31:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/453113002/20001

[commit-bot: I haz the power, 2014-08-09 18:28:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19130)

[commit-bot: I haz the power, 2014-08-09 18:53:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-09 18:53:05]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[abarth-chromium, 2014-08-11 19:31:18]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-08-11 19:32:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/453113002/40001

[commit-bot: I haz the power, 2014-08-11 20:33:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)

[commit-bot: I haz the power, 2014-08-11 21:05:53]

Change committed as 179990