Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: Source/core/rendering/RenderLayer.h

Issue 453113002: RenderLayer::hasVisibleContent should ASSERT(!m_visibleContentStatusDirty) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Slightly less Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderBlockFlow.cpp ('k') | Source/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 void clearBlockSelectionGapsBounds(); 163 void clearBlockSelectionGapsBounds();
164 void invalidatePaintForBlockSelectionGaps(); 164 void invalidatePaintForBlockSelectionGaps();
165 IntRect blockSelectionGapsBounds() const; 165 IntRect blockSelectionGapsBounds() const;
166 bool hasBlockSelectionGapBounds() const; 166 bool hasBlockSelectionGapBounds() const;
167 167
168 RenderLayerStackingNode* stackingNode() { return m_stackingNode.get(); } 168 RenderLayerStackingNode* stackingNode() { return m_stackingNode.get(); }
169 const RenderLayerStackingNode* stackingNode() const { return m_stackingNode. get(); } 169 const RenderLayerStackingNode* stackingNode() const { return m_stackingNode. get(); }
170 170
171 bool subtreeIsInvisible() const { return !hasVisibleContent() && !hasVisible Descendant(); } 171 bool subtreeIsInvisible() const { return !hasVisibleContent() && !hasVisible Descendant(); }
172 172
173 // FIXME: We should ASSERT(!m_visibleContentStatusDirty) here, but see https ://bugs.webkit.org/show_bug.cgi?id=71044 173 // FIXME: hasVisibleContent() should call updateDescendantDependentFlags() i f m_visibleContentStatusDirty.
174 // ditto for hasVisibleDescendant(), see https://bugs.webkit.org/show_bug.cg i?id=71277 174 bool hasVisibleContent() const { ASSERT(!m_visibleContentStatusDirty); retur n m_hasVisibleContent; }
175 bool hasVisibleContent() const { return m_hasVisibleContent; } 175
176 // FIXME: hasVisibleDescendant() should call updateDescendantDependentFlags( ) if m_visibleDescendantStatusDirty.
176 bool hasVisibleDescendant() const { ASSERT(!m_visibleDescendantStatusDirty); return m_hasVisibleDescendant; } 177 bool hasVisibleDescendant() const { ASSERT(!m_visibleDescendantStatusDirty); return m_hasVisibleDescendant; }
177 178
178 void setHasVisibleContent(); 179 void setHasVisibleContent();
179 void dirtyVisibleContentStatus(); 180 void dirtyVisibleContentStatus();
181 void potentiallyDirtyVisibleContentStatus(EVisibility);
180 182
181 bool hasBoxDecorationsOrBackground() const; 183 bool hasBoxDecorationsOrBackground() const;
182 bool hasVisibleBoxDecorations() const; 184 bool hasVisibleBoxDecorations() const;
183 // Returns true if this layer has visible content (ignoring any child layers ). 185 // Returns true if this layer has visible content (ignoring any child layers ).
184 bool isVisuallyNonEmpty() const; 186 bool isVisuallyNonEmpty() const;
185 // True if this layer container renderers that paint. 187 // True if this layer container renderers that paint.
186 bool hasNonEmptyChildRenderers() const; 188 bool hasNonEmptyChildRenderers() const;
187 189
188 // FIXME: We should ASSERT(!m_hasSelfPaintingLayerDescendantDirty); here but we hit the same bugs as visible content above. 190 // FIXME: We should ASSERT(!m_hasSelfPaintingLayerDescendantDirty); here but we hit the same bugs as visible content above.
189 // Part of the issue is with subtree relayout: we don't check if our ancesto rs have some descendant flags dirty, missing some updates. 191 // Part of the issue is with subtree relayout: we don't check if our ancesto rs have some descendant flags dirty, missing some updates.
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
733 735
734 } // namespace blink 736 } // namespace blink
735 737
736 #ifndef NDEBUG 738 #ifndef NDEBUG
737 // Outside the WebCore namespace for ease of invocation from gdb. 739 // Outside the WebCore namespace for ease of invocation from gdb.
738 void showLayerTree(const blink::RenderLayer*); 740 void showLayerTree(const blink::RenderLayer*);
739 void showLayerTree(const blink::RenderObject*); 741 void showLayerTree(const blink::RenderObject*);
740 #endif 742 #endif
741 743
742 #endif // RenderLayer_h 744 #endif // RenderLayer_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBlockFlow.cpp ('k') | Source/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698