Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 453023002: Revert of Enable HTMLMediaElement@autoplay on Android (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
CC:
avayvod+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, David Trainor- moved to gerrit, jam, nasko+codewatch_chromium.org, qinmin, chrishtr
Project:
chromium
Visibility:
Public.

Description

Revert of Enable HTMLMediaElement@autoplay on Android (https://codereview.chromium.org/447353002/) Reason for revert: I misunderstood the outcome of the discussion surrounding this topic. We need to keep this code in order to not break google.com while gathering data about this feature. Original issue's description: > Enable HTMLMediaElement@autoplay on Android > > This CL sets user_gesture_required_for_media_playback to false in Chrome for > Android. Previously, we removed this requirement as a special case for the > Google Search Results page. Now that this setting matches Chrome's behavior on > other platforms, we don't need the special case for google.com and can remove > the entire VoiceSearchTabHelper. > > This CL leaves the user_gesture_required_for_media_playback WebPreference > because that's used by android_webview. > > R=klobag@chromium.org, darin@chromium.org > BUG=178297 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288308 TBR=darin@chromium.org,klobag@chromium.org NOTREECHECKS=true NOTRY=true BUG=178297 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 3 chunks +3 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/VoiceSearchTabHelper.java View 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/browser/android/voice_search_tab_helper.h View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/android/voice_search_tab_helper.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/media/media_source_browsertest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
Created Revert of Enable HTMLMediaElement@autoplay on Android
6 years, 4 months ago (2014-08-08 17:48:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/453023002/1
6 years, 4 months ago (2014-08-08 17:50:12 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 17:52:15 UTC) #3
Message was sent while issue was closed.
Change committed as 288389

Powered by Google App Engine
This is Rietveld 408576698