Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 447353002: Enable HTMLMediaElement@autoplay on Android (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
CC:
avayvod+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, David Trainor- moved to gerrit, jam, nasko+codewatch_chromium.org, qinmin, chrishtr
Project:
chromium
Visibility:
Public.

Description

Enable HTMLMediaElement@autoplay on Android This CL sets user_gesture_required_for_media_playback to false in Chrome for Android. Previously, we removed this requirement as a special case for the Google Search Results page. Now that this setting matches Chrome's behavior on other platforms, we don't need the special case for google.com and can remove the entire VoiceSearchTabHelper. This CL leaves the user_gesture_required_for_media_playback WebPreference because that's used by android_webview. R=klobag@chromium.org, darin@chromium.org BUG=178297 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288308

Patch Set 1 #

Patch Set 2 : More removals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -136 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 3 chunks +0 lines, -3 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/VoiceSearchTabHelper.java View 1 chunk +0 lines, -32 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/android/voice_search_tab_helper.h View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/android/voice_search_tab_helper.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/media/media_source_browsertest.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
abarth-chromium
6 years, 4 months ago (2014-08-07 18:39:24 UTC) #1
abarth-chromium
6 years, 4 months ago (2014-08-07 18:44:41 UTC) #2
darin (slow to review)
LGTM
6 years, 4 months ago (2014-08-07 20:06:09 UTC) #3
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-08 03:43:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/447353002/20001
6 years, 4 months ago (2014-08-08 03:45:16 UTC) #5
commit-bot: I haz the power
Change committed as 288308
6 years, 4 months ago (2014-08-08 10:25:56 UTC) #6
abarth-chromium
6 years, 4 months ago (2014-08-08 17:48:11 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/453023002/ by abarth@chromium.org.

The reason for reverting is: I misunderstood the outcome of the discussion
surrounding this topic. We need to keep this code in order to not break
google.com while gathering data about this feature..

Powered by Google App Engine
This is Rietveld 408576698