Chromium Code Reviews| Index: base/metrics/field_trial_unittest.cc |
| diff --git a/base/metrics/field_trial_unittest.cc b/base/metrics/field_trial_unittest.cc |
| index 866095ca66e74d81ae7245fa62e569d35a9ed892..a2baf4fca1e310a99055e9c2f7b393c834e5e535 100644 |
| --- a/base/metrics/field_trial_unittest.cc |
| +++ b/base/metrics/field_trial_unittest.cc |
| @@ -397,6 +397,15 @@ TEST_F(FieldTrialTest, Restore) { |
| ASSERT_NE(static_cast<FieldTrial*>(NULL), trial); |
| EXPECT_EQ("yyyy", trial->group_name()); |
| EXPECT_EQ("xxx", trial->trial_name()); |
| + |
| + EXPECT_TRUE(FieldTrialList::CreateTrialsFromString( |
|
Alexei Svitkine (slow)
2014/08/08 18:28:48
Create a new test case for this, instead of groupi
gayane -on leave until 09-2017
2014/08/08 18:50:16
Done.
|
| + "tname/gname", FieldTrialList::DONT_ACTIVATE_TRIALS, |
| + std::set<std::string>())); |
| + |
| + trial = FieldTrialList::Find("tname"); |
| + ASSERT_NE(static_cast<FieldTrial*>(NULL), trial); |
| + EXPECT_EQ("gname", trial->group_name()); |
| + EXPECT_EQ("tname", trial->trial_name()); |
| } |
| TEST_F(FieldTrialTest, BogusRestore) { |
| @@ -407,9 +416,6 @@ TEST_F(FieldTrialTest, BogusRestore) { |
| "MissingGroupName/", FieldTrialList::DONT_ACTIVATE_TRIALS, |
| std::set<std::string>())); |
| EXPECT_FALSE(FieldTrialList::CreateTrialsFromString( |
| - "MissingFinalSlash/gname", FieldTrialList::DONT_ACTIVATE_TRIALS, |
| - std::set<std::string>())); |
| - EXPECT_FALSE(FieldTrialList::CreateTrialsFromString( |
| "noname, only group/", FieldTrialList::DONT_ACTIVATE_TRIALS, |
| std::set<std::string>())); |
| } |