Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: base/metrics/field_trial.cc

Issue 452923003: CreateTrailsFromString function now accepts argument without last separator symbol (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/metrics/field_trial_unittest.cc » ('j') | base/metrics/field_trial_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/field_trial.cc
diff --git a/base/metrics/field_trial.cc b/base/metrics/field_trial.cc
index 54b95211470ffc4acc0ea793895de4c939e889ec..450f92f34c2c2d8e09f5ae160c2a026f1209eacf 100644
--- a/base/metrics/field_trial.cc
+++ b/base/metrics/field_trial.cc
@@ -414,16 +414,16 @@ bool FieldTrialList::CreateTrialsFromString(
return false;
size_t group_name_end = trials_string.find(kPersistentStringSeparator,
name_end + 1);
- if (group_name_end == trials_string.npos || name_end + 1 == group_name_end)
+ if (name_end + 1 == group_name_end)
return false;
+ if (group_name_end == trials_string.npos)
+ group_name_end = trials_string.length();
std::string name(trials_string, next_item, name_end - next_item);
std::string group_name(trials_string, name_end + 1,
group_name_end - name_end - 1);
next_item = group_name_end + 1;
-
Alexei Svitkine (slow) 2014/08/08 18:28:48 Nit: Restore the existing whitespace as it was bef
gayane -on leave until 09-2017 2014/08/08 18:50:16 Done.
if (ignored_trial_names.find(name) != ignored_trial_names.end())
continue;
-
FieldTrial* trial = CreateFieldTrial(name, group_name);
if (!trial)
return false;
« no previous file with comments | « no previous file | base/metrics/field_trial_unittest.cc » ('j') | base/metrics/field_trial_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698