Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/base/cdm_promise_unittest.cc

Issue 452643002: Add UMA reporting to CdmPromise. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Actually add the test. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/base/cdm_promise.cc ('K') | « media/base/cdm_promise.cc ('k') | media/base/media_keys.h » ('j') | media/base/media_keys.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/cdm_promise_unittest.cc
diff --git a/media/base/scoped_histogram_timer_unittest.cc b/media/base/cdm_promise_unittest.cc
similarity index 55%
copy from media/base/scoped_histogram_timer_unittest.cc
copy to media/base/cdm_promise_unittest.cc
index 47e228eb1113cba8c29d919cd66854b580b19848..44ae1e675c94f842010863b56e0dc504f1cade7e 100644
--- a/media/base/scoped_histogram_timer_unittest.cc
+++ b/media/base/cdm_promise_unittest.cc
@@ -2,15 +2,14 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "base/time/time.h"
-#include "media/base/scoped_histogram_timer.h"
+#include "media/base/cdm_promise.h"
+#include "media/base/media_keys.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace media {
-TEST(ScopedHistogramTimer, TwoTimersOneScope) {
- SCOPED_UMA_HISTOGRAM_TIMER("TestTimer0");
- SCOPED_UMA_HISTOGRAM_TIMER("TestTimer1");
+TEST(CdmPromise, ResultCodeForUMAInSync) {
+ EXPECT_EQ(MediaKeys::NUM_EXCEPTIONS, CdmPromise::NUM_RESULT_CODES - 1);
ddorwin 2014/08/08 18:29:04 This can be a COMPILE_ASSERT at the conversion sit
sandersd (OOO until July 31) 2014/08/08 19:32:45 Done.
}
} // namespace media
« media/base/cdm_promise.cc ('K') | « media/base/cdm_promise.cc ('k') | media/base/media_keys.h » ('j') | media/base/media_keys.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698