media/base/cdm_promise_unittest.cc - Issue 452643002: Add UMA reporting to CdmPromise.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/base/cdm_promise_unittest.cc

Issue 452643002: Add UMA reporting to CdmPromise. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actually add the test. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/time/time.h"	5 #include "media/base/cdm_promise.h"

6 #include "media/base/scoped_histogram_timer.h"	6 #include "media/base/media_keys.h"

7 #include "testing/gtest/include/gtest/gtest.h"	7 #include "testing/gtest/include/gtest/gtest.h"

8	8

9 namespace media {	9 namespace media {

10	10

11 TEST(ScopedHistogramTimer, TwoTimersOneScope) {	11 TEST(CdmPromise, ResultCodeForUMAInSync) {

12 SCOPED_UMA_HISTOGRAM_TIMER("TestTimer0");	12 EXPECT_EQ(MediaKeys::NUM_EXCEPTIONS, CdmPromise::NUM_RESULT_CODES - 1);
	ddorwin 2014/08/08 18:29:04 This can be a COMPILE_ASSERT at the conversion sit This can be a COMPILE_ASSERT at the conversion site. sandersd (OOO until July 31) 2014/08/08 19:32:45 Done. Show quoted text On 2014/08/08 18:29:04, ddorwin wrote: > This can be a COMPILE_ASSERT at the conversion site. Done.
13 SCOPED_UMA_HISTOGRAM_TIMER("TestTimer1");

14 }	13 }

15	14

16 } // namespace media	15 } // namespace media

OLD	NEW