Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 452543002: Build only the appropriate x86 arches for nacl (chrome side). (Closed)

Created:
6 years, 4 months ago by bradn
Modified:
6 years, 3 months ago
Reviewers:
Mark Seaborn, bbudge, brettw, jam
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Build only the appropriate x86 arches for nacl (chrome side). BUG=https://code.google.com/p/chromium/issues/detail?id=388101 TEST=local + with trybots R=mseaborn@chromium.org,jam@chromium.org,brettw@chromium.org Committed: https://crrev.com/5c5b64142652bfa57a4309602892765b889350dc Cr-Commit-Position: refs/heads/master@{#294987}

Patch Set 1 #

Patch Set 2 : drop deps #

Total comments: 1

Patch Set 3 : fix #

Patch Set 4 : fix #

Patch Set 5 : fix more #

Patch Set 6 : fixxx #

Patch Set 7 : fix #

Patch Set 8 : fix #

Patch Set 9 : fix more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -23 lines) Patch
M build/common_untrusted.gypi View 1 2 3 4 5 2 chunks +12 lines, -1 line 0 comments Download
M ppapi/native_client/native_client.gyp View 2 chunks +11 lines, -3 lines 0 comments Download
M ppapi/ppapi_nacl.gyp View 1 2 3 4 5 6 7 8 7 chunks +42 lines, -18 lines 0 comments Download
M ppapi/ppapi_nacl_test_common.gypi View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
bradn
6 years, 4 months ago (2014-08-07 19:21:45 UTC) #1
Mark Seaborn
LGTM, but please test this via a clobber build before committing. https://codereview.chromium.org/452543002/diff/20001/ppapi/native_client/native_client.gyp File ppapi/native_client/native_client.gyp (right): ...
6 years, 4 months ago (2014-08-07 19:30:47 UTC) #2
Mark Seaborn
I spoke too soon. It looks like this fails on the trybots: create_nmf.py: cannot find ...
6 years, 4 months ago (2014-08-07 19:31:59 UTC) #3
jam
lgtm, thanks
6 years, 4 months ago (2014-08-08 01:27:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/452543002/160001
6 years, 3 months ago (2014-09-16 00:37:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/11155)
6 years, 3 months ago (2014-09-16 01:18:23 UTC) #8
bbudge
Rubberstamp lgtm
6 years, 3 months ago (2014-09-16 02:14:55 UTC) #10
brettw
rs lgtm
6 years, 3 months ago (2014-09-16 02:17:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/452543002/160001
6 years, 3 months ago (2014-09-16 02:19:13 UTC) #13
commit-bot: I haz the power
Committed patchset #9 (id:160001) as 9386fe3d8d3d6fd481d09eb445e3827cba5d76bb
6 years, 3 months ago (2014-09-16 02:31:23 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 02:34:43 UTC) #15
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/5c5b64142652bfa57a4309602892765b889350dc
Cr-Commit-Position: refs/heads/master@{#294987}

Powered by Google App Engine
This is Rietveld 408576698