Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: ppapi/ppapi_nacl.gyp

Issue 452543002: Build only the appropriate x86 arches for nacl (chrome side). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix more Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/native_client/native_client.gyp ('k') | ppapi/ppapi_nacl_test_common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/ppapi_nacl.gyp
diff --git a/ppapi/ppapi_nacl.gyp b/ppapi/ppapi_nacl.gyp
index a93fdb92b867c4ce05446f40f2750333aefc6e36..1d75eed8539be5bb8897faabbd29049697e1ff59 100644
--- a/ppapi/ppapi_nacl.gyp
+++ b/ppapi/ppapi_nacl.gyp
@@ -8,7 +8,7 @@
{
'includes': [
- '../native_client/build/untrusted.gypi',
+ '../build/common_untrusted.gypi',
'ppapi_sources.gypi',
],
'targets': [
@@ -100,24 +100,26 @@
'-O0',
],
'conditions': [
- ['target_arch=="ia32" or target_arch=="x64"', {
- 'extra_deps_newlib64': [
- '>(tc_lib_dir_newlib64)/libppapi_cpp.a',
- '>(tc_lib_dir_newlib64)/libppapi.a',
- ],
+ ['target_arch=="ia32"', {
'extra_deps_newlib32': [
'>(tc_lib_dir_newlib32)/libppapi_cpp.a',
'>(tc_lib_dir_newlib32)/libppapi.a',
],
- 'extra_deps_glibc64': [
- '>(tc_lib_dir_glibc64)/libppapi_cpp.so',
- '>(tc_lib_dir_glibc64)/libppapi.so',
- ],
'extra_deps_glibc32': [
'>(tc_lib_dir_glibc32)/libppapi_cpp.so',
'>(tc_lib_dir_glibc32)/libppapi.so',
],
}],
+ ['target_arch=="x64" or (target_arch=="ia32" and OS=="win")', {
+ 'extra_deps_newlib64': [
+ '>(tc_lib_dir_newlib64)/libppapi_cpp.a',
+ '>(tc_lib_dir_newlib64)/libppapi.a',
+ ],
+ 'extra_deps_glibc64': [
+ '>(tc_lib_dir_glibc64)/libppapi_cpp.so',
+ '>(tc_lib_dir_glibc64)/libppapi.so',
+ ],
+ }],
['target_arch=="arm"', {
'extra_deps_arm': [
'>(tc_lib_dir_newlib_arm)/libppapi_cpp.a',
@@ -140,7 +142,7 @@
'create_nonsfi_test_nmf': 'tests/create_nonsfi_test_nmf.py',
},
'conditions': [
- ['target_arch!="arm" and target_arch!="mipsel" and disable_glibc==0', {
+ ['(target_arch=="ia32" or target_arch=="x64") and disable_glibc==0', {
'variables': {
'build_glibc': 1,
# NOTE: Use /lib, not /lib64 here; it is a symbolic link which
@@ -155,7 +157,7 @@
'action_name': 'Generate GLIBC NMF and copy libs',
# NOTE: create_nmf must be first, it is the script python executes
# below.
- 'inputs': ['>(create_nmf)', '>(out_glibc64)', '>(out_glibc32)'],
+ 'inputs': ['>(create_nmf)'],
# NOTE: There is no explicit dependency for the lib32
# and lib64 directories created in the PRODUCT_DIR.
# They are created as a side-effect of NMF creation.
@@ -164,13 +166,25 @@
'python',
'>@(_inputs)',
'--objdump=>(nacl_objdump)',
- '--library-path=>(libdir_glibc64)',
- '--library-path=>(libdir_glibc32)',
- '--library-path=>(tc_lib_dir_glibc32)',
- '--library-path=>(tc_lib_dir_glibc64)',
'--output=>(nmf_glibc)',
'--stage-dependencies=<(PRODUCT_DIR)',
],
+ 'conditions': [
+ ['target_arch=="ia32"', {
+ 'action': [
+ '--library-path=>(libdir_glibc32)',
+ '--library-path=>(tc_lib_dir_glibc32)',
+ ],
+ 'inputs': ['>(out_glibc32)'],
+ }],
+ ['target_arch=="x64" or (target_arch=="ia32" and OS=="win")', {
+ 'action': [
+ '--library-path=>(libdir_glibc64)',
+ '--library-path=>(tc_lib_dir_glibc64)',
+ ],
+ 'inputs': ['>(out_glibc64)'],
+ }],
+ ],
},
],
}],
@@ -199,8 +213,6 @@
# below.
'inputs': [
'>(create_nmf)',
- '>(out_pnacl_newlib_x86_32_nexe)',
- '>(out_pnacl_newlib_x86_64_nexe)'
],
'outputs': ['>(nmf_pnacl)'],
'action': [
@@ -208,6 +220,18 @@
'>@(_inputs)',
'--output=>(nmf_pnacl)',
],
+ 'conditions': [
+ ['target_arch=="ia32"', {
+ 'inputs': [
+ '>(out_pnacl_newlib_x86_32_nexe)',
+ ],
+ }],
+ ['target_arch=="x64" or (target_arch=="ia32" and OS=="win")', {
+ 'inputs': [
+ '>(out_pnacl_newlib_x86_64_nexe)',
+ ],
+ }],
+ ],
},
],
}],
« no previous file with comments | « ppapi/native_client/native_client.gyp ('k') | ppapi/ppapi_nacl_test_common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698