Issue 452523002: Add ValidateAndMeasurePage to PageTest; this is a replacement for both ValidatePage and MeasurePage.

Issue 452523002: Add ValidateAndMeasurePage to PageTest; this is a replacement for both ValidatePage and MeasurePage. (Closed)

Created:
6 years, 4 months ago by chrishenry

Modified:
6 years, 4 months ago

Reviewers:
nednguyen, Ken Russell (switch to Gerrit)

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add ValidateAndMeasurePage to PageTest; this is a replacement for both ValidatePage and MeasurePage. Usage will be cleaned up in subsequent patch(es), along with killing PageMeasurement. BUG=383635 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288291

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix more doc. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -36 lines)			Patch
	M	tools/telemetry/telemetry/page/page_test.py	View	1	4 chunks	+33 lines, -34 lines	0 comments	Download
	M	tools/telemetry/telemetry/page/page_test_unittest.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

nednguyen

+kbr https://codereview.chromium.org/452523002/diff/1/tools/telemetry/telemetry/page/page_test.py File tools/telemetry/telemetry/page/page_test.py (right): https://codereview.chromium.org/452523002/diff/1/tools/telemetry/telemetry/page/page_test.py#newcode293 tools/telemetry/telemetry/page/page_test.py:293: You will remove these 2 in next patch?

6 years, 4 months ago (2014-08-07 19:28:05 UTC) #2

chrishenry

https://codereview.chromium.org/452523002/diff/1/tools/telemetry/telemetry/page/page_test.py File tools/telemetry/telemetry/page/page_test.py (right): https://codereview.chromium.org/452523002/diff/1/tools/telemetry/telemetry/page/page_test.py#newcode293 tools/telemetry/telemetry/page/page_test.py:293: On 2014/08/07 19:28:05, nednguyen wrote: > You will remove ...

6 years, 4 months ago (2014-08-07 19:33:31 UTC) #3

nednguyen

LGTM Please wait for Ken's approval also, I am not very good at naming.

6 years, 4 months ago (2014-08-07 19:36:46 UTC) #4

Ken Russell (switch to Gerrit)

Thanks for the CC:. Seems fine. LGTM

6 years, 4 months ago (2014-08-07 23:51:33 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/452523002/20001

6 years, 4 months ago (2014-08-08 00:54:50 UTC) #7

Message was sent while issue was closed.

Change committed as 288291

Expand Messages | Collapse Messages