tools/telemetry/telemetry/page/page_test_unittest.py - Issue 452523002: Add ValidateAndMeasurePage to PageTest; this is a replacement for both ValidatePage and MeasurePage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_test_unittest.py

Issue 452523002: Add ValidateAndMeasurePage to PageTest; this is a replacement for both ValidatePage and MeasurePage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix more doc. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_test_unittest.py

diff --git a/tools/telemetry/telemetry/page/page_test_unittest.py b/tools/telemetry/telemetry/page/page_test_unittest.py

index 56b4a6a458daa6bb068ce453cfada2ab9fa7c437..6b068bf04be4ef94ec94de96385471546001a1f6 100644

--- a/tools/telemetry/telemetry/page/page_test_unittest.py

+++ b/tools/telemetry/telemetry/page/page_test_unittest.py

@@ -10,7 +10,7 @@ from telemetry.page import page_test

class DoNothingPageTest(page_test.PageTest):

- def ValidatePage(self, *_):

+ def ValidateAndMeasurePage(self, *_):

pass

@@ -22,8 +22,8 @@ class TestPage(page_module.Page):

def RunActionToRun(self, _):

self.run_action_to_run_called = True

-class PageTestUnitTest(unittest.TestCase):

+class PageTestUnitTest(unittest.TestCase):

def testRunActions(self):

test = DoNothingPageTest('RunActionToRun')

page = TestPage('file://blank.html', None, util.GetUnittestDataDir())

« no previous file with comments | « tools/telemetry/telemetry/page/page_test.py ('k') | no next file » | no next file with comments »