Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 452493005: --runOnce -> --loops 1 (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
bsalomon, borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : separate args #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M slave/skia_slave_scripts/run_nanobench.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
6 years, 4 months ago (2014-08-07 20:16:00 UTC) #1
bsalomon
Eric, PTAL. Needed for https://codereview.chromium.org/450743002
6 years, 4 months ago (2014-08-07 20:17:19 UTC) #2
borenet
https://codereview.chromium.org/452493005/diff/1/slave/skia_slave_scripts/run_nanobench.py File slave/skia_slave_scripts/run_nanobench.py (right): https://codereview.chromium.org/452493005/diff/1/slave/skia_slave_scripts/run_nanobench.py#newcode63 slave/skia_slave_scripts/run_nanobench.py:63: args.append('--loops 1') # Don't care about performance on Valgrind. ...
6 years, 4 months ago (2014-08-07 20:18:54 UTC) #3
mtklein
https://codereview.chromium.org/452493005/diff/1/slave/skia_slave_scripts/run_nanobench.py File slave/skia_slave_scripts/run_nanobench.py (right): https://codereview.chromium.org/452493005/diff/1/slave/skia_slave_scripts/run_nanobench.py#newcode63 slave/skia_slave_scripts/run_nanobench.py:63: args.append('--loops 1') # Don't care about performance on Valgrind. ...
6 years, 4 months ago (2014-08-07 20:20:42 UTC) #4
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-08-07 20:23:52 UTC) #5
borenet
On 2014/08/07 20:23:52, bsalomon wrote: > The CQ bit was checked by mailto:bsalomon@google.com LGTM
6 years, 4 months ago (2014-08-07 20:24:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/452493005/20001
6 years, 4 months ago (2014-08-07 20:24:47 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 20:38:40 UTC) #8
Message was sent while issue was closed. 
Change committed as 6ab3aea6fe1973a6cd406a122e2c2f478423d0e2

Powered by Google App Engine
This is Rietveld 408576698