slave/skia_slave_scripts/run_nanobench.py - Issue 452493005: --runOnce -> --loops 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: slave/skia_slave_scripts/run_nanobench.py

Issue 452493005: --runOnce -> --loops 1 (Closed) Base URL: https://skia.googlesource.com/buildbot@master

Patch Set: separate args Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: slave/skia_slave_scripts/run_nanobench.py

diff --git a/slave/skia_slave_scripts/run_nanobench.py b/slave/skia_slave_scripts/run_nanobench.py

index 57446659cd22a6145416be5dff8c5ed3a8bc9d4b..13f5de43e3e1ef62a23d9472d60e9a070dc95571 100644

--- a/slave/skia_slave_scripts/run_nanobench.py

+++ b/slave/skia_slave_scripts/run_nanobench.py

@@ -60,7 +60,7 @@ class RunNanobench(BuildStep):

'--skps', self._device_dirs.SKPDir(),

'--scales', '1.0', '1.1']

if self._AnyMatch('Valgrind'):

- args.append('--runOnce') # Don't care about performance on Valgrind.

+ args.extend(['--loops', '1']) # Don't care about performance on Valgrind.

elif self._perf_data_dir:

args.extend([

'--outResultsFile', self._JSONPath(),

« no previous file with comments | « no previous file | no next file » | no next file with comments »