Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 452413002: [Refactor]: Move drag_widget_ out of X11WholeScreenMoveLoop (Closed)

Created:
6 years, 4 months ago by pkotwicz
Modified:
6 years, 4 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, dcheng
Project:
chromium
Visibility:
Public.

Description

[Refactor]: Move drag_widget_ out of X11WholeScreenMoveLoop BUG=None Test=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289026

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -99 lines) Patch
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h View 4 chunks +15 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 7 chunks +77 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_move_loop.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h View 3 chunks +0 lines, -14 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc View 7 chunks +0 lines, -71 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pkotwicz
Elliot, PTAL
6 years, 4 months ago (2014-08-09 19:50:54 UTC) #1
Elliot Glaysher
lgtm
6 years, 4 months ago (2014-08-11 18:05:27 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 4 months ago (2014-08-12 14:20:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/452413002/80001
6 years, 4 months ago (2014-08-12 14:22:40 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 18:16:41 UTC) #5
Message was sent while issue was closed.
Change committed as 289026

Powered by Google App Engine
This is Rietveld 408576698