Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h

Issue 452413002: [Refactor]: Move drag_widget_ out of X11WholeScreenMoveLoop (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h
diff --git a/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h b/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h
index e4a8adad1ef4bd6e01c7bcee295a756e0fd469bc..b82cb58cdf0a7bba36022411c57215b1b9eb9668 100644
--- a/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h
+++ b/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h
@@ -46,8 +46,6 @@ class X11WholeScreenMoveLoop : public X11MoveLoop,
gfx::NativeCursor cursor) OVERRIDE;
virtual void UpdateCursor(gfx::NativeCursor cursor) OVERRIDE;
virtual void EndMoveLoop() OVERRIDE;
- virtual void SetDragImage(const gfx::ImageSkia& image,
- const gfx::Vector2dF& offset) OVERRIDE;
private:
// Grabs the pointer and keyboard, setting the mouse cursor to |cursor|.
@@ -57,13 +55,6 @@ class X11WholeScreenMoveLoop : public X11MoveLoop,
// Creates an input-only window to be used during the drag.
Window CreateDragInputWindow(XDisplay* display);
- // Creates a window to show the drag image during the drag.
- void CreateDragImageWindow();
-
- // Checks to see if |in_image| is an image that has any visible regions
- // (defined as having a pixel with alpha > 32). If so, return true.
- bool CheckIfIconValid();
-
// Dispatch mouse movement event to |delegate_| in a posted task.
void DispatchMouseMovement();
@@ -89,11 +80,6 @@ class X11WholeScreenMoveLoop : public X11MoveLoop,
// Keeps track of whether we still have a pointer grab at the end of the loop.
bool has_grab_;
- // A Widget is created during the drag if there is an image available to be
- // used during the drag.
- scoped_ptr<Widget> drag_widget_;
- gfx::ImageSkia drag_image_;
- gfx::Vector2dF drag_offset_;
XMotionEvent last_xmotion_;
base::WeakPtrFactory<X11WholeScreenMoveLoop> weak_factory_;
« no previous file with comments | « ui/views/widget/desktop_aura/x11_move_loop.h ('k') | ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698