Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 452233002: Make BBH::search() const. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Make BBH::search() const. I'd like to have SkRecordDraw() work with a const SkBBoxHierarchy*, but can't quite today. The only interesting change here is no longer flushing if needed in RTree; instead we assert we've been flushed already. BUG=skia: Committed: https://skia.googlesource.com/skia/+/8875a0413686eb3dc9f7d7d18a2cee9076aade54

Patch Set 1 #

Total comments: 2

Patch Set 2 : More const for tile() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
M src/core/SkBBoxHierarchy.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkQuadTree.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkQuadTree.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRTree.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkRTree.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M src/core/SkTileGrid.h View 1 4 chunks +7 lines, -3 lines 0 comments Download
M src/core/SkTileGrid.cpp View 1 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-08 18:16:23 UTC) #1
mtklein
6 years, 4 months ago (2014-08-08 18:16:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/452233002/1
6 years, 4 months ago (2014-08-08 18:17:23 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-08 18:17:24 UTC) #4
robertphillips
https://codereview.chromium.org/452233002/diff/1/src/core/SkTileGrid.h File src/core/SkTileGrid.h (right): https://codereview.chromium.org/452233002/diff/1/src/core/SkTileGrid.h#newcode77 src/core/SkTileGrid.h:77: private: can this return "const SkTDArray<void>&" ?
6 years, 4 months ago (2014-08-08 18:24:23 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-08 18:37:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/452233002/20001
6 years, 4 months ago (2014-08-08 18:38:40 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-08 18:38:41 UTC) #8
mtklein
https://codereview.chromium.org/452233002/diff/1/src/core/SkTileGrid.h File src/core/SkTileGrid.h (right): https://codereview.chromium.org/452233002/diff/1/src/core/SkTileGrid.h#newcode77 src/core/SkTileGrid.h:77: private: On 2014/08/08 18:24:23, robertphillips wrote: > can this ...
6 years, 4 months ago (2014-08-08 18:38:50 UTC) #9
robertphillips
lgtm
6 years, 4 months ago (2014-08-08 18:39:51 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 18:49:45 UTC) #11
Message was sent while issue was closed.
Change committed as 8875a0413686eb3dc9f7d7d18a2cee9076aade54

Powered by Google App Engine
This is Rietveld 408576698