Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 451953002: Add owners and descripts to some Chrome Now metrics actions. (Closed)

Created:
6 years, 4 months ago by skare_
Modified:
6 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add owners and descriptions to some Chrome Now metrics actions. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289161

Patch Set 1 #

Total comments: 1

Patch Set 2 : htmlescape quotes to " #

Patch Set 3 : add 'the' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -14 lines) Patch
M tools/metrics/actions/actions.xml View 1 2 2 chunks +34 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
skare_
6 years, 4 months ago (2014-08-09 00:43:25 UTC) #1
robliao
lgtm https://codereview.chromium.org/451953002/diff/1/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/451953002/diff/1/tools/metrics/actions/actions.xml#newcode2949 tools/metrics/actions/actions.xml:2949: User dismissed the Now Notifications welcome toast via ...
6 years, 4 months ago (2014-08-10 02:20:21 UTC) #2
Alexei Svitkine (slow)
LGTM, thanks!
6 years, 4 months ago (2014-08-11 14:58:51 UTC) #3
skare_
The CQ bit was checked by skare@chromium.org
6 years, 4 months ago (2014-08-12 16:58:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skare@chromium.org/451953002/1
6 years, 4 months ago (2014-08-12 17:01:09 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-12 17:12:02 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 17:24:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/3679)
6 years, 4 months ago (2014-08-12 17:24:06 UTC) #8
skare_
The CQ bit was checked by skare@chromium.org
6 years, 4 months ago (2014-08-12 22:55:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skare@chromium.org/451953002/40001
6 years, 4 months ago (2014-08-12 23:52:05 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 02:53:08 UTC) #11
Message was sent while issue was closed. 
Change committed as 289161

Powered by Google App Engine
This is Rietveld 408576698