Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: tools/metrics/actions/actions.xml

Issue 451953002: Add owners and descripts to some Chrome Now metrics actions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add 'the' Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index cef55cad9fa72ce5fc69b3a59e6778c99d35aaa6..ac2bc609c7a6ad5875c7f6f2b87f6f839d30d699 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -2896,18 +2896,25 @@ should be able to be added at any place in this file.
</action>
<action name="GoogleNow.ButtonClicked0">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
+ <owner>robliao@chromium.org</owner>
+ <owner>skare@chromium.org</owner>
+ <description>
+ User clicked button index 0 (0-based) of a Now Notification.
+ </description>
</action>
<action name="GoogleNow.ButtonClicked1">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
+ <owner>robliao@chromium.org</owner>
+ <owner>skare@chromium.org</owner>
+ <description>
+ User clicked button index 1 (0-based) of a Now Notification.
+ </description>
</action>
<action name="GoogleNow.Dismissed">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
+ <owner>robliao@chromium.org</owner>
+ <owner>skare@chromium.org</owner>
+ <description>User dismissed a Now Notification.</description>
</action>
<action name="GoogleNow.MessageCenter.NotificationPoppedUp">
@@ -2919,23 +2926,36 @@ should be able to be added at any place in this file.
</action>
<action name="GoogleNow.MessageClicked">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
+ <owner>robliao@chromium.org</owner>
+ <owner>skare@chromium.org</owner>
+ <description>
+ User clicked on the message text of a Now notification.
+ </description>
</action>
<action name="GoogleNow.WelcomeToastClickedNo">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
+ <owner>robliao@chromium.org</owner>
+ <owner>skare@chromium.org</owner>
+ <description>
+ User dismissed the Now Notifications welcome toast via the &quot;don't show
+ me notifications&quot; button.
+ </description>
</action>
<action name="GoogleNow.WelcomeToastClickedYes">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
+ <owner>robliao@chromium.org</owner>
+ <owner>skare@chromium.org</owner>
+ <description>
+ User dismissed the Now Notifications welcome toast via the ok button.
+ </description>
</action>
<action name="GoogleNow.WelcomeToastDismissed">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
+ <owner>robliao@chromium.org</owner>
+ <owner>skare@chromium.org</owner>
+ <description>
+ User dismissed the Now Notifications welcome toast via the x.
+ </description>
</action>
<action name="GpuAccelerationDisabled">
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698