Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 451883002: Update SIMD version of life demo. (Closed)

Created:
6 years, 4 months ago by nfullagar1
Modified:
6 years, 4 months ago
Reviewers:
nfullagar, binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Project:
chromium
Visibility:
Public.

Description

Update SIMD version of life demo. - add benchmark option - add multi-thread support - convert from c to cpp (inc. ppapi) BUG=NONE TEST=this is a demo R=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288473

Patch Set 1 #

Total comments: 12

Patch Set 2 : changes for binji's suggestions #

Patch Set 3 : remove commented out js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+594 lines, -461 lines) Patch
M native_client_sdk/src/examples/demo/life_simd/example.dsc View 1 chunk +7 lines, -4 lines 0 comments Download
A native_client_sdk/src/examples/demo/life_simd/example.js View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
M native_client_sdk/src/examples/demo/life_simd/index.html View 1 chunk +12 lines, -0 lines 0 comments Download
D native_client_sdk/src/examples/demo/life_simd/life.c View 1 chunk +0 lines, -457 lines 0 comments Download
A native_client_sdk/src/examples/demo/life_simd/life.cc View 1 1 chunk +524 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nfullagar1
6 years, 4 months ago (2014-08-07 22:41:40 UTC) #1
binji
lgtm https://codereview.chromium.org/451883002/diff/1/native_client_sdk/src/examples/demo/life_simd/example.js File native_client_sdk/src/examples/demo/life_simd/example.js (right): https://codereview.chromium.org/451883002/diff/1/native_client_sdk/src/examples/demo/life_simd/example.js#newcode19 native_client_sdk/src/examples/demo/life_simd/example.js:19: simd = document.getElementById('simd'); var simd https://codereview.chromium.org/451883002/diff/1/native_client_sdk/src/examples/demo/life_simd/example.js#newcode21 native_client_sdk/src/examples/demo/life_simd/example.js:21: 'value' ...
6 years, 4 months ago (2014-08-08 00:31:40 UTC) #2
nfullagar
https://codereview.chromium.org/451883002/diff/1/native_client_sdk/src/examples/demo/life_simd/example.js File native_client_sdk/src/examples/demo/life_simd/example.js (right): https://codereview.chromium.org/451883002/diff/1/native_client_sdk/src/examples/demo/life_simd/example.js#newcode19 native_client_sdk/src/examples/demo/life_simd/example.js:19: simd = document.getElementById('simd'); On 2014/08/08 00:31:40, binji wrote: > ...
6 years, 4 months ago (2014-08-08 20:51:48 UTC) #3
nfullagar
The CQ bit was checked by nfullagar@google.com
6 years, 4 months ago (2014-08-08 20:51:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@chromium.org/451883002/40001
6 years, 4 months ago (2014-08-08 20:54:06 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 00:11:30 UTC) #6
Message was sent while issue was closed.
Change committed as 288473

Powered by Google App Engine
This is Rietveld 408576698