Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Issue 451773002: Android: fix battery status API charging state. (Closed)

Created:
6 years, 4 months ago by timvolodine
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Android: fix battery status API charging state. Define charging attribute in terms of whether the device is plugged in or not. Previously it was defined in terms of BATTERY_STATUS_DISCHARGING property but some phones report BATTERY_STATUS_NOT_CHARGING when the battery is not charging. Also modified the tests accordingly. TEST=http://jsbin.com/battery-status-test BUG=360068 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288361

Patch Set 1 #

Patch Set 2 : added comment regarding charging/discharing time. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -12 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java View 1 2 chunks +12 lines, -8 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/BatteryStatusManagerTest.java View 4 chunks +35 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
timvolodine
6 years, 4 months ago (2014-08-07 18:35:09 UTC) #1
timvolodine
6 years, 4 months ago (2014-08-08 11:40:26 UTC) #2
Miguel Garcia
lgtm
6 years, 4 months ago (2014-08-08 11:43:14 UTC) #3
Michael van Ouwerkerk
lgtm
6 years, 4 months ago (2014-08-08 12:17:24 UTC) #4
timvolodine
The CQ bit was checked by timvolodine@chromium.org
6 years, 4 months ago (2014-08-08 13:09:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/451773002/20001
6 years, 4 months ago (2014-08-08 13:10:52 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-08 14:35:51 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 15:00:39 UTC) #8
Message was sent while issue was closed.
Change committed as 288361

Powered by Google App Engine
This is Rietveld 408576698