Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java

Issue 451773002: Android: fix battery status API charging state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added comment regarding charging/discharing time. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/BatteryStatusManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java b/content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java
index 5153143dcacb873dcbb20a30b792e80d1cec7c55..8e586ebe94c1f4d5079986eddeea4abce6354050 100644
--- a/content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java
+++ b/content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java
@@ -91,13 +91,18 @@ class BatteryStatusManager {
boolean present = ignoreBatteryPresentState() ?
true : intent.getBooleanExtra(BatteryManager.EXTRA_PRESENT, false);
+ int pluggedStatus = intent.getIntExtra(BatteryManager.EXTRA_PLUGGED, -1);
- if (!present) {
- // No battery, return default values.
+ if (!present || pluggedStatus == -1) {
+ // No battery or no plugged status: return default values.
gotBatteryStatus(true, 0, Double.POSITIVE_INFINITY, 1);
return;
}
+ boolean charging = pluggedStatus != 0;
+ int status = intent.getIntExtra(BatteryManager.EXTRA_STATUS, -1);
+ boolean batteryFull = status == BatteryManager.BATTERY_STATUS_FULL;
+
int current = intent.getIntExtra(BatteryManager.EXTRA_LEVEL, -1);
int max = intent.getIntExtra(BatteryManager.EXTRA_SCALE, -1);
double level = (double)current / (double)max;
@@ -106,12 +111,11 @@ class BatteryStatusManager {
level = 1.0;
}
- int status = intent.getIntExtra(BatteryManager.EXTRA_STATUS, -1);
- boolean charging = !(status == BatteryManager.BATTERY_STATUS_DISCHARGING);
-
- // TODO(timvolodine) : add proper projection for chargingTime, dischargingTime.
- double chargingTime = (status == BatteryManager.BATTERY_STATUS_FULL) ?
- 0 : Double.POSITIVE_INFINITY;
+ // Currently Android does not provide charging/discharging time, as a work-around
+ // we could compute it manually based on level delta.
+ // TODO(timvolodine): add proper projection for chargingTime, dischargingTime
+ // (see crbug.com/401553).
+ double chargingTime = (charging & batteryFull) ? 0 : Double.POSITIVE_INFINITY;
double dischargingTime = Double.POSITIVE_INFINITY;
gotBatteryStatus(charging, chargingTime, dischargingTime, level);
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/BatteryStatusManagerTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698