Add fade to white animation when power button is pressed on Athena

Add fade to white animation when power button is pressed on Athena

BUG=398935
TEST=Manual, see bug
R=oshima
TBR=sky (For addition of DEPS to athena/system)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288482

[pkotwicz, 2014-08-07 18:08:11]

flackr@ PTAL

[flackr, 2014-08-07 18:23:31]

Looks good, just a few questions. +oshima for ui animation location.

https://codereview.chromium.org/451753002/diff/20001/athena/system/power_butt...
File athena/system/power_button_controller.cc (right):

https://codereview.chromium.org/451753002/diff/20001/athena/system/power_butt...
athena/system/power_button_controller.cc:60: layer->SetLayerGrayscale(target);
Defer to oshima, but I suspect we'll want these animations to be done by the
athena screen manager rather than doing UI things from athena/system.

https://codereview.chromium.org/451753002/diff/20001/athena/system/power_butt...
athena/system/power_button_controller.cc:86: if (!can_cancel_shutdown_)
Seems a bit arbitrary to no longer allow canceling shutdown once the animation
completes. Couldn't the posted task be canceled?

[oshima, 2014-08-07 19:53:38]

https://codereview.chromium.org/451753002/diff/20001/athena/system/power_butt...
File athena/system/power_button_controller.cc (right):

https://codereview.chromium.org/451753002/diff/20001/athena/system/power_butt...
athena/system/power_button_controller.cc:60: layer->SetLayerGrayscale(target);
On 2014/08/07 18:23:31, flackr wrote:
> Defer to oshima, but I suspect we'll want these animations to be done by the
> athena screen manager rather than doing UI things from athena/system.

I'm actually fine to implement the animation itself outside of the screen
manager, but want to hind RootWindow.

How about adding ScreenManager::CreateScreenAnimator()? Since we need similar
animation for ctrl-shift-q,
I think this should be a separate clsss/function.

https://codereview.chromium.org/451753002/diff/20001/athena/system/power_butt...
athena/system/power_button_controller.cc:86: if (!can_cancel_shutdown_)
can we use state enum rather than multiple booleans?

[pkotwicz, 2014-08-08 01:22:22]

Rob and Oshima, can you please take another look?

I have removed the delay between the animation ending and sending the D-Bus
request. Ash has this delay, but I cannot see a difference with or without it.

[oshima, 2014-08-08 14:56:59]

https://codereview.chromium.org/451753002/diff/60001/athena/screen/public/scr...
File athena/screen/public/screen_manager.h (right):

https://codereview.chromium.org/451753002/diff/60001/athena/screen/public/scr...
athena/screen/public/screen_manager.h:70: virtual scoped_ptr<ScreenAnimator>
CreateScreenAnimator() = 0;
Sorry if I wasn't clear. I meant

ui::LayerAnimator ScreenManager::GetScreenAnimator();

Animation itself should be in other place (system is fine fornow)

I probably will rework a bit on this API (thinking of an animation object you
can apply), but the above API is good for now.

[pkotwicz, 2014-08-08 20:22:40]

Oshima, can you please take another look?

[oshima, 2014-08-08 20:36:52]

lgtm

https://codereview.chromium.org/451753002/diff/100001/athena/system/power_but...
File athena/system/power_button_controller.cc (right):

https://codereview.chromium.org/451753002/diff/100001/athena/system/power_but...
athena/system/power_button_controller.cc:49: animator->SetGrayscale(target);
FYI: I'll probably move this out to somewhere, but it's ok to be here for now.

[pkotwicz, 2014-08-08 21:17:03]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-08-08 21:19:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/451753002/100001

[pkotwicz, 2014-08-08 21:36:16]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2014-08-08 21:36:45]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-08-08 21:38:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/451753002/100001

[commit-bot: I haz the power, 2014-08-09 00:57:53]

Change committed as 288482