Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 451723002: Remove never-happen if statement in WebExternalTextureLayerImpl. (Closed)

Created:
6 years, 4 months ago by dshwang
Modified:
6 years, 4 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove never-happen if statement in WebExternalTextureLayerImpl. Now this condition never happens after r287686 and BUG=344393 r287686 got rid of lost_resource from this condition. BUG=344393 made a client never destructed before releasing all mailboxes. BUG=344393 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M content/renderer/compositor_bindings/web_external_texture_layer_impl.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dshwang
Hi, could you review? It's follow-up cl of https://codereview.chromium.org/369823002 https://codereview.chromium.org/169933002
6 years, 4 months ago (2014-08-07 15:32:31 UTC) #1
enne (OOO)
lgtm
6 years, 4 months ago (2014-08-07 17:03:34 UTC) #2
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 4 months ago (2014-08-07 17:42:17 UTC) #3
dshwang
On 2014/08/07 17:03:34, enne wrote: > lgtm Thank you for quick review.
6 years, 4 months ago (2014-08-07 17:42:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/451723002/1
6 years, 4 months ago (2014-08-07 17:56:43 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-07 18:57:10 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 22:53:22 UTC) #7
Message was sent while issue was closed.
Change committed as 288157

Powered by Google App Engine
This is Rietveld 408576698