|
|
Created:
6 years, 5 months ago by Hongbo Min Modified:
6 years, 4 months ago CC:
chromium-reviews, darin-cc_chromium.org, inactive_dshwang_plz_cc_intel, jam, Shouqun Liu Base URL:
https://chromium.googlesource.com/chromium/src@master Project:
chromium Visibility:
Public. |
DescriptionForward along the lost_resource to layer client
Forward the boolean flag indicating if the resource is lost and let
canvas handle how to handle the lost resource, not simply ignore to
call mailboxReleased.
BUG=390960
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287686
Patch Set 1 #
Messages
Total messages: 26 (0 generated)
This is the chromium part for the CL at https://codereview.chromium.org/369043003/. Could you please have a review? Thanks.
LG once you have blink side sorted out.
You can't land this yet since it won't compile, but might as well LGTM
On 2014/07/03 15:09:47, danakj wrote: > You can't land this yet since it won't compile, but might as well LGTM It is not clear whether this change will be needed in the end, so let's wait and see where the blink side takes us. If we do end up needing this, lgtm 2
@kbr, for your information.
Thanks for the heads up.
The CQ bit was checked by hongbo.min@intel.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hongbo.min@intel.com/369823002/1
enne@, I need your lgtm to commit this CL. Thanks!
The CQ bit was unchecked by hongbo.min@intel.com
On 2014/07/23 06:06:57, Hongbo Min wrote: > The CQ bit was unchecked by mailto:hongbo.min@intel.com hi, junov@, would you please instruct me how to make the trybots sync with the required blink commit to make them green? Thanks.
On 2014/07/23 09:52:36, Hongbo Min wrote: > On 2014/07/23 06:06:57, Hongbo Min wrote: > > The CQ bit was unchecked by mailto:hongbo.min@intel.com > > hi, junov@, would you please instruct me how to make the trybots sync with the > required blink commit to make them green? Thanks. The WebCore namespace was renamed to blink. I looks like your try jobs were sent while the code was in the middle of that transition. Just re-try and I think it should work.
The CQ bit was checked by junov@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hongbo.min@intel.com/369823002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
@nduca, does this CL look good to you? thanks.
On 2014/07/24 01:19:39, Hongbo Min wrote: > @nduca, does this CL look good to you? thanks. ping @nduca and @enne
non-owner lgtm
dana or enne should review, i am not current on this code
I LGTM'd earlier, this is a good thing. But I'm not OWNERS over here.
rslgtm
The CQ bit was checked by hongbo.min@intel.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hongbo.min@intel.com/369823002/1
Message was sent while issue was closed.
Change committed as 287686 |