Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 369823002: Forward the boolean flag indicating if the resource is lost to canvas (Closed)

Created:
6 years, 5 months ago by Hongbo Min
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, inactive_dshwang_plz_cc_intel, jam, Shouqun Liu
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Forward along the lost_resource to layer client Forward the boolean flag indicating if the resource is lost and let canvas handle how to handle the lost resource, not simply ignore to call mailboxReleased. BUG=390960 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287686

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/compositor_bindings/web_external_texture_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
Hongbo Min
This is the chromium part for the CL at https://codereview.chromium.org/369043003/. Could you please have a ...
6 years, 5 months ago (2014-07-03 08:27:25 UTC) #1
danakj
LG once you have blink side sorted out.
6 years, 5 months ago (2014-07-03 15:09:24 UTC) #2
danakj
You can't land this yet since it won't compile, but might as well LGTM
6 years, 5 months ago (2014-07-03 15:09:47 UTC) #3
Justin Novosad
On 2014/07/03 15:09:47, danakj wrote: > You can't land this yet since it won't compile, ...
6 years, 5 months ago (2014-07-07 15:17:08 UTC) #4
Hongbo Min
@kbr, for your information.
6 years, 5 months ago (2014-07-17 01:41:18 UTC) #5
Ken Russell (switch to Gerrit)
Thanks for the heads up.
6 years, 5 months ago (2014-07-17 18:31:31 UTC) #6
Hongbo Min
The CQ bit was checked by hongbo.min@intel.com
6 years, 5 months ago (2014-07-23 05:56:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hongbo.min@intel.com/369823002/1
6 years, 5 months ago (2014-07-23 05:57:41 UTC) #8
Hongbo Min
enne@, I need your lgtm to commit this CL. Thanks!
6 years, 5 months ago (2014-07-23 06:05:52 UTC) #9
Hongbo Min
The CQ bit was unchecked by hongbo.min@intel.com
6 years, 5 months ago (2014-07-23 06:06:57 UTC) #10
Hongbo Min
On 2014/07/23 06:06:57, Hongbo Min wrote: > The CQ bit was unchecked by mailto:hongbo.min@intel.com hi, ...
6 years, 5 months ago (2014-07-23 09:52:36 UTC) #11
Justin Novosad
On 2014/07/23 09:52:36, Hongbo Min wrote: > On 2014/07/23 06:06:57, Hongbo Min wrote: > > ...
6 years, 5 months ago (2014-07-23 15:33:43 UTC) #12
Justin Novosad
The CQ bit was checked by junov@chromium.org
6 years, 5 months ago (2014-07-23 15:34:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hongbo.min@intel.com/369823002/1
6 years, 5 months ago (2014-07-23 15:36:14 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 19:37:55 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 19:42:39 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/81842)
6 years, 5 months ago (2014-07-23 19:42:40 UTC) #17
Hongbo Min
@nduca, does this CL look good to you? thanks.
6 years, 5 months ago (2014-07-24 01:19:39 UTC) #18
Hongbo Min
On 2014/07/24 01:19:39, Hongbo Min wrote: > @nduca, does this CL look good to you? ...
6 years, 4 months ago (2014-07-31 07:15:26 UTC) #19
dshwang
non-owner lgtm
6 years, 4 months ago (2014-07-31 07:41:58 UTC) #20
nduca
dana or enne should review, i am not current on this code
6 years, 4 months ago (2014-08-05 01:07:07 UTC) #21
danakj
I LGTM'd earlier, this is a good thing. But I'm not OWNERS over here.
6 years, 4 months ago (2014-08-05 13:25:21 UTC) #22
enne (OOO)
rslgtm
6 years, 4 months ago (2014-08-05 17:06:48 UTC) #23
Hongbo Min
The CQ bit was checked by hongbo.min@intel.com
6 years, 4 months ago (2014-08-06 01:15:32 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hongbo.min@intel.com/369823002/1
6 years, 4 months ago (2014-08-06 01:18:07 UTC) #25
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 05:45:38 UTC) #26
Message was sent while issue was closed.
Change committed as 287686

Powered by Google App Engine
This is Rietveld 408576698