Clean up IC tracing for CallICs.

Clean up IC tracing for CallICs.

CallICs have had some confused tracing, because the IC state is not
entirely captured by the installed code stub - it lives in the type
vector.

Change tracing to be able to use the vector state changes instead.
Introduced a DEFAULT state to be used by all vector-based ICs.

R=verwaest@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=22978

[mvstanton, 2014-08-07 12:41:50]

Hi Toon,
This CL tries to clarify state and reporting concerns for vector-based ICs.
PTAL, thanks!
--Michael

[Toon Verwaest, 2014-08-07 13:07:47]

LGTM (with some tiny style nits)

https://codereview.chromium.org/451643002/diff/1/src/ic.cc
File src/ic.cc (right):

https://codereview.chromium.org/451643002/diff/1/src/ic.cc#newcode2006
src/ic.cc:2006: Handle<Object> name(isolate()->factory()->empty_string());
name = isolate()->factory()->empty_string()

https://codereview.chromium.org/451643002/diff/1/src/ic.cc#newcode2009
src/ic.cc:2009: name = Handle<Object>(js_function->shared()->name(), isolate());
handle(js_function->shared()->name(), isolate())

https://codereview.chromium.org/451643002/diff/1/src/ic.cc#newcode2024
src/ic.cc:2024: Handle<Object> name(isolate()->factory()->empty_string());
name = isolate()->factory()->empty_string()

https://codereview.chromium.org/451643002/diff/1/src/ic.cc#newcode2056
src/ic.cc:2056: name = Handle<Object>(js_function->shared()->name(), isolate());
handle(js_function->shared()->name(), isolate())

[mvstanton, 2014-08-07 14:10:19]

Right on, thanks much!

https://codereview.chromium.org/451643002/diff/1/src/ic.cc
File src/ic.cc (right):

https://codereview.chromium.org/451643002/diff/1/src/ic.cc#newcode2006
src/ic.cc:2006: Handle<Object> name(isolate()->factory()->empty_string());
On 2014/08/07 13:07:46, Toon Verwaest wrote:
> name = isolate()->factory()->empty_string()

Done.

https://codereview.chromium.org/451643002/diff/1/src/ic.cc#newcode2009
src/ic.cc:2009: name = Handle<Object>(js_function->shared()->name(), isolate());
On 2014/08/07 13:07:46, Toon Verwaest wrote:
> handle(js_function->shared()->name(), isolate())

Done.

https://codereview.chromium.org/451643002/diff/1/src/ic.cc#newcode2024
src/ic.cc:2024: Handle<Object> name(isolate()->factory()->empty_string());
On 2014/08/07 13:07:46, Toon Verwaest wrote:
> name = isolate()->factory()->empty_string()

Done.

https://codereview.chromium.org/451643002/diff/1/src/ic.cc#newcode2056
src/ic.cc:2056: name = Handle<Object>(js_function->shared()->name(), isolate());
On 2014/08/07 13:07:46, Toon Verwaest wrote:
> handle(js_function->shared()->name(), isolate())

Done.

[mvstanton, 2014-08-07 15:33:27]

Committed patchset #2 manually as 22978 (presubmit successful).